Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 224289 - ConfigurationWrapper should be lazier in EclipseTouchpoint
Summary: ConfigurationWrapper should be lazier in EclipseTouchpoint
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M6   Edit
Assignee: P2 Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-27 00:15 EDT by Simon Kaegi CLA
Modified: 2008-03-28 03:16 EDT (History)
1 user (show)

See Also:

Attachments
patch (6.53 KB, patch)
2008-03-27 00:30 EDT, Simon Kaegi CLA 		no flags Details | Diff
replacement bundle for I20080327-0100 (71.26 KB, application/x-zip-compressed)
2008-03-27 15:50 EDT, Simon Kaegi CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Kaegi CLA 2008-03-27 00:15:05 EDT 
The ConfigurationWrapper's constructor causes the LazyManipulator to activate when it looks for the OSGiInstallArea. On my laptop with the SDK installed this adds a fixed cost of 600ms in the prephase to initialize the manipulator and about 1200ms in the post phase to save the manipulator. This occurs whenever an OSGi bundle is involved even if no "manipulating is being done. For the default phaseset this adds a fixed cost of around 10s. For typical install/uninstall scenarios we should be able to reduce this by about 8s.

We can defer the lookup of the OSGiInstallArea in the configuration wrapper and save the time when no "real" manipulation is done.
Comment 1 Simon Kaegi CLA 2008-03-27 00:30:40 EDT 
Created attachment 93750 [details]
patch
Comment 2 Simon Kaegi CLA 2008-03-27 00:44:31 EDT 
I just did a little testing of this patch comparing a basic sdk install vs. an sdk with tptp install and found that this patch provides a "fixed" reduction of about 8s seemingly independent of the number of bundles installed.
Comment 3 Simon Kaegi CLA 2008-03-27 15:50:48 EDT 
Created attachment 93861 [details]
replacement bundle for I20080327-0100
Comment 4 Simon Kaegi CLA 2008-03-27 18:13:25 EDT 
path released. marking fixed.