Community
Participate
Working Groups
Created attachment 93175 [details] The feature.xml file for org.eclipse.birt feature In the attached feature.xml file (as part of BIRT report framework package), the IU "org.eclipse.birt.report.designer.editor.xml.wtp" should be an optional entry as specified: <includes id="org.eclipse.birt.report.designer.editor.xml.wtp" version="2.3.0.v20080320-0800" optional="true" /> (Note: This IU actually has a dependency on WTP. The intent for making it optional is that, when WTP is not installed, this IU would not be used, while the rest of BIRT pieces can still be used.) However, during the install through the Software Updates UI from P2, this causes the unsatisfied dependency errors (as in the attached screenshot), and block the install. Notes: 1. eclipse-SDK-I20080320-0800-win32.zip was used. 2. If the "includes" element mentioned above is removed from the feature.xml, the install completes successfully, and the code works properly. So, the problem seems to be related to the dependency check does not handle the optional IU properly.
Created attachment 93176 [details] Errors in P2 install UI Screenshot attached.
Looks like an obvious copy-paste bug. In o.e.e.internal.p2.metadata.generator.features.FeatureParser, code for processing included features is: private void processIncludes(Attributes attributes) { FeatureEntry entry = new FeatureEntry(...); ... String flag = attributes.getValue("unpack"); //$NON-NLS-1$ if (flag != null) entry.setOptional(Boolean.valueOf(flag).booleanValue()); ... } Should be getValue("optional");
Fix for bug 223529: P2 does not handle optional IU properly Optional includes were not correctly processed by metadata generation due (evidently) to a copy/paste bug. The processing of includes in FeatureParser was incorrectly setting the optional value in FeatureEntry using the value of the "pack" property. Changed this to use the value of the "optional" property.
Can this be marked fixed? I see the fix was released.
To be fully functional this will need some code from the patch_support branch of the director.
In Ecipse M5 update manager, the update install is also blocked by missing wtp features, which is required by optional features.
Xiaoying, about the issue you mentioned in Comment #6, can you provide more specific descriptions to the p2 team on how the installation was set up with Eclipse M5 and how to reproduce the blocking install scenario? This would help the p2 team on its investigation on the issue and come up a resolution. Thanks.
My senario is: 1. Install Eclipse SDK I20080326-1319-win32. 2. Unzip GEF m5, EMF m5, DTP m5, BIRT framework M5 into dropins folder with eclipse root folder. 3. BIRT report design function works well. 4. Click "Software updates..." and create a new local site, which contains the new BIRT features 5. Select "Lowagie iText Feature" from Local Update Site. Note that, this feature is a 3rd party feature and do not have dependency on any other features. 6. After the "Resolving dependencies" dialogue, a "Question" dialogue pops up and prompt that the feature I select may not be valid. 7. In the details dialogue next, it says that org.eclipse.birt.report.desginer.editor.xml.wtp.feature.group requires org.eclipse.wst.common_ui.feature. 8 Then I clicked "cancel" button to exit.(Other buttons are all invalid) It seems the installation of iText feature will check the dependency of birt feature? The same situation happened when I try to uninstall the iText feature from SDK. Then I switched to "Classic Update" views. 1. Add local update site as above steps and try to install iText feature. 2. Installed successfully. 3. I tried to install BIRT framework, which contains an optional sub-feature that requires wtp. 4. The error message pops up that emf features are missing. So install other Ganymede projects features/plugins into "dropins" folders do not work for the "Classic Update". I have to install these dependencies features thru update site again. Finally after I installed emf, gef, dtp thru update manage, I got the error message "org.eclipse.wst.common_ui.feature...is missing", which is what I expected.
Testing with new I20080327 build(http://download.eclipse.org/eclipse/downloads/drops/I20080327-0100/index.php) 3rd party features can be installed successfully from P2 update manager. But birt frawework feature, which includes an optional sub-feature that requires wtp installation still got error and blocker the process.
Created attachment 93951 [details] error log snapshot from build I20080327-0100
Could you please give a try to this week I build?
I tried my simple scenario on the platform SDK M6 build, and the BIRT installation (without WTP) went through fine. Xiaoying, you should still go through your (more elaborative) scenario to verify it as well.
I installed eclipse-SDK-I20080410-1022-win32.zip with EMF 2.4M6, GEF 3.4M6, DTP 1.6M6 and tried to install BIRT framework M6 from BIRT update site (http://download.eclipse.org/birt/update-site/2.3/). Error still occurs: No IU found to satisfy dependency from org.eclipse.birt.report.designer.editor.xml.wtp.feature.group 2.3.0.v20080313-35-03f_w_H2s-Thpxz-JdHz01HOL to requiredCapability: org.eclipse.equinox.p2.iu/org.eclipse.wst.common_ui.feature.feature.group/3.0.0. No IU found to satisfy dependency from org.eclipse.birt.report.designer.editor.xml.wtp.feature.group 2.3.0.v20080313-35-03f_w_H2s-Thpxz-JdHz01HOL to requiredCapability: org.eclipse.equinox.p2.iu/org.eclipse.wst.xml_ui.feature.feature.group/3.0.0. No IU found to satisfy dependency from org.eclipse.birt.report.designer.editor.xml.wtp.feature.group 2.3.0.v20080313-35-03f_w_H2s-Thpxz-JdHz01HOL to requiredCapability: org.eclipse.equinox.p2.iu/org.eclipse.wst.xml_ui.feature.feature.group/3.0.0.
Potential dup of bug 226666
This issue can be manifested in several forms -- from the update site (which Xiaoying mentioned) and from local sites (which point to the downloaded/unzipped bits). This affects the developers who need a target environment for creating an application that leverages BIRT. Currently, it is scheduled for M7. Would the fix be delivered in the M7 milestone build (or sooner)?
It will be in next week I build. *** This bug has been marked as a duplicate of bug 228481 ***
