Community
Participate
Working Groups
Using I-I20080320095049-20080320095049 The JSF facet creates, among other things, a Faces servlet and mappings, and adds them into the projet's web model. This has suddenly stopped working and our code has not changed. A J2EE (v2.4 Web module) model updates fine. Steps to reproduce: 1) create dynamic web app with 2.5 web module 2) add JSF v1.2 facet (this will require creating a JSF implementation library from the JSF install property page, but that can be completely bogus) 3) Finish Result: The web.xml file will lack a Faces Servlet entry and mapping. Code can be found at org.eclipse.jst.jsf.core.internal.project.facet.JSFFacetInstallDelegate.
Kiril, can you take a look - recent regression with new models?
I confirm this is reproduced with build I20080320151231.
Hi Gerry, Until the resolution of bug 198815 the model provider was working with only one instance of a model object. Modify method was working in all situations. With the merged model provider we have introduced the notation of a: Merged model Dd model Annotation model Since there is currently no support of modifying the annotation model, during the modify method we are providing the dd model as the instance to be modified. So all the modifications go to the dd model. Which is then persisted. If you have previously get an instance to the merged model you CAN NOT use this instance during the modify method. You should get a new instance to the model object in the runnable method. This from my point of view is consistent with the documentation of IModelProvider:modify which states that: * Note: All implementors need to ensure all model access using this instance within the runnable block * Use a cached/consistent view of the model that is being modified So during the runnable block you will be provided with a consistent view of the model. You must just call modelProvider.getModelObject() in the begining of the runnable block. Most of the runnables for model modifications work in this way.
Created attachment 93098 [details] fixes jsf creation. This is one way to fix the creation. The modelObject in this case during the modify will be the XML model for sure.
Thanks all. I have checked in and released the fix in our code.
Verified fixed using I20080321174820
Closed for I20080321174820
