Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 223341 - [ui] Would like to install everything in a category
Summary: [ui] Would like to install everything in a category
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.4 M7   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 223931 227691 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-03-20 09:17 EDT by DJ Houghton CLA
Modified: 2008-04-24 17:08 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description DJ Houghton CLA 2008-03-20 09:17:11 EDT
One of our customers mentioned that the "install" button is disabled when they select a category. In this case they would like to be given the option to install everything in the category.
Comment 1 Susan McCourt CLA 2008-03-20 11:58:39 EDT
Consider for 3.4.
Probably would consider "category = all IUs in category" only if no other IU was selected in the category itself.
Comment 2 Susan McCourt CLA 2008-03-25 16:31:56 EDT
*** Bug 223931 has been marked as a duplicate of this bug. ***
Comment 3 Nick Boldt CLA 2008-03-25 19:22:22 EDT
If a category is selected AND something in the category is selected, I think I'd still want everything in the category to be installed. It's like if I select a folder and a file inside the folder, then copy the selection. I'd expect to get a copy of both things -- the parent folder and the child file, or better yet, just the parent folder.

(But I may be unique in that view...)
Comment 4 Susan McCourt CLA 2008-03-25 19:48:39 EDT
seems reasonable
Comment 5 Susan McCourt CLA 2008-04-15 17:46:11 EDT
looking at this for M7 as I'm in the selection enablement right now anyway.
Comment 6 Susan McCourt CLA 2008-04-16 13:08:51 EDT
Fixed in HEAD >20080416.
Selecting a category implies the selection of its members.

I debated a bit over whether selecting a repo implies the selection of its members.  From a conceptual point of view, it should, it's just another container.  But there are performance issues since the moment you select a repo it would get loaded.

Here's what I ended up doing...If a repo has not been loaded, it is not considered in the selection.  From a UI point of view, it means that if you are viewing available software by site, and you select a site without expanding it, you won't be able to install by selecting the site.  Once the site is expanded, it is considered as a container.  This is to prevent over-eager loading of repos.

If you expand a site and then collapse it, then it is loaded, and selecting it would consider all of its members.  Note that you always get the list of what's about to be installed, so you'll see the result of your selections before anything happens.

My hope here is that it will seemingly "do the right thing" as far as the users are concerned.  But if we get questions/confusion over this issue, then I'll keep metadata repos out of the selection consideration.
Comment 7 Susan McCourt CLA 2008-04-17 22:10:22 EDT
*** Bug 227691 has been marked as a duplicate of this bug. ***
Comment 8 Susan McCourt CLA 2008-04-24 17:08:55 EDT
Per bug #224445, there is now a nicer visual indication of what the selection model is for sites and categories because we use the checkbox state of the children to reinforce what will happen when a container is selected.

Also, the oddities with sites are a bit improved.
>if  you select a site without expanding it,
>you won't be able to install by selecting the site.  
>Once the site is expanded,
>it is considered as a container. 

Now that we have check boxes, checking a site will expand the site automatically.  The assumption is that the user intends to load the repo if they are going to install everything underneath it.  We didn't use this before because selecting (vs. checking) a site was a lighter weight operation.