This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 223241 - Full screen mode toolbar button
Summary: Full screen mode toolbar button
Status: VERIFIED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Cosmos (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Leonard Richardson CLA
QA Contact:
URL:
Whiteboard: useability
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-19 14:53 EDT by amehrega CLA
Modified: 2012-01-03 13:55 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description amehrega CLA 2008-03-19 14:53:30 EDT
COSMOS client should provide the ability to maximize/restore a view via a toolbar button.  It's currently difficult to view a report when the data manager and the properties view are present.  Analysis of a report will be much easier if we have a mechanism that will allow users to maximize the details view.

Similarly, we need to provide this mechanism for the properties view.
Comment 1 amehrega CLA 2008-05-06 10:28:03 EDT
I'm guessing this will be based on the floating layout which you've already included an example under org.eclipse.cosmos.dr.tests.views/WebContent/pages/floatingLayout.

It includes a maximize button which works as expected.  There are however problems when floating the widget.  We probably just need to extend our current layouts to include the same maximize/restore button.
Comment 2 Sheldon Lee-Loy CLA 2008-05-06 10:41:06 EDT
What problems are you referring to?

I restricted the user from moving and resizing the panes manually.   If this is the case I need a restore button to restore the layout.  
Comment 3 amehrega CLA 2008-05-06 10:55:18 EDT
(In reply to comment #2)
> What problems are you referring to?

Occasionally the container would follow my mouse cursor even when I had released the mouse button.

> I restricted the user from moving and resizing the panes manually.   

That should solve the problem.

Comment 4 Sheldon Lee-Loy CLA 2008-05-23 12:00:24 EDT
(In reply to comment #3)
> (In reply to comment #2)
> > What problems are you referring to?
> 
> Occasionally the container would follow my mouse cursor even when I had
> released the mouse button.
> 
> > I restricted the user from moving and resizing the panes manually.   
> 
> That should solve the problem.
> 

I can't disable the ability to move the pane.  This is a configuration limitation with the current implementation.  The mouse cursor problem is a dojo bug.

Note that the floating pane widget provided by dojo 1.0 states that it's experimental.  I'm not sure if we should add this capability in the i11 release since the floating panes don't behave in an expected manner.  

I can create a different page template for the COSMOSUI.  The user can access this page by typing http://localhost:8080/COSMOSUI/?page=floatingpane.  However by default the user would work with the original page template that doesn't let the user maximize the views.

What do you think?
Comment 5 amehrega CLA 2008-05-23 13:19:42 EDT
The widget is actually pretty stable.  The gap between mouse clicks has to be small for the floating container to follow the cursor with the mouse click released.

I recommend going ahead with using the widget.  Creating an alternative page will hide the functionality.  We can always revert back to the original if there is negative reaction from the community.
Comment 6 Sheldon Lee-Loy CLA 2008-05-23 13:28:28 EDT
(In reply to comment #5)

You should try it in Internet Explorer.  You will see that it's unstable.
Comment 7 amehrega CLA 2008-05-23 14:12:40 EDT
(In reply to comment #6)
> (In reply to comment #5)
> 
> You should try it in Internet Explorer.  You will see that it's unstable.
> 

Yeh, it appears a lot buggier in IE than in FireFox.  Instead of using a floating layout, is it possible to extend our current container to include a maximize button? 

Clicking on the button will hide all other containers and maximize its size to fit the screen.
Comment 8 Sheldon Lee-Loy CLA 2008-05-29 00:07:53 EDT
(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #5)
> > 
> > You should try it in Internet Explorer.  You will see that it's unstable.
> > 
> 
> Yeh, it appears a lot buggier in IE than in FireFox.  Instead of using a
> floating layout, is it possible to extend our current container to include a
> maximize button? 
> 
> Clicking on the button will hide all other containers and maximize its size to
> fit the screen.
> 

I tried to include just a maximize button.  Everything works fine in Firefox but there are weird problems with IE.  The scroll bars and grid widget behave irregularly.
Comment 9 amehrega CLA 2008-05-29 08:42:35 EDT
> I tried to include just a maximize button.  Everything works fine in Firefox
> but there are weird problems with IE.  The scroll bars and grid widget behave
> irregularly.


Ideally we would want to provide cross-browser support but if that's unlikely for i11, then I suggest only enabling the maximize button in FireFox.
Comment 10 Sheldon Lee-Loy CLA 2008-05-29 11:57:49 EDT
I will see if this is possible for i11..  However this ER may be pushed out due to resource constraints.
Comment 11 Sheldon Lee-Loy CLA 2008-06-25 13:28:54 EDT
Reassigning to Martin as discussed in DV call
Comment 12 Sheldon Lee-Loy CLA 2008-06-27 09:50:29 EDT
Making these ERs as Bugs since design docs aren't required.
Comment 13 Sheldon Lee-Loy CLA 2008-07-09 09:59:07 EDT
Moving bugs to i13 as discussed in DV call.
Comment 14 Leonard Richardson CLA 2008-08-19 06:40:08 EDT
Changed fixed split windows to floating windows with maximise button
and fixed floating window to redraw in its previous location when restoring after a maximise.
Comment 15 Sheldon Lee-Loy CLA 2008-08-28 13:34:27 EDT
Verified with build COSMOS-1.0.0-200808281255
Comment 16 Srinivas Reddy CLA 2008-09-15 06:54:02 EDT
QA Review for JUnits/Manual tests:
No explicit test cases were defined, however it has tested and verified as part of i13 end2end demo.