Community
Participate
Working Groups
Build ID: I20080314 In the following file: ECLIPSE\PLUGINS\ORG.ECLIPSE.TPTP.TEST.RECORDERS.URL\URLRECORDER.UI_JAR\ORG\ECLIPSE\TPTP\TEST\RECORDERS\URL\UI\INTERNAL\RESOURCES\ MESSAGES.PROPERTIES JAVA2-PRB I have found 2 consecutive single quotes in text not handled by Java MessageFormat class. Please remove 1 quote. Line: 51 More information:
This is caused by the comment that determines the type of single quote handling (see http://www.eclipse.org/tptp/home/documents/process/development/plugin_translatability_faq.html#920). Since all properties (except plugin.properties) are processed by org.eclipse.osgi.util.NLS, confirming is we should be using the NLS_MESSAGEFORMAT_NONE designation.
According to the JavaDoc for the NLS class, the NLS#bind methods perform string substitution and should be considered a convenience for MessageFormat#format method calls. The same single quote handling based on the criteria should still be used. Do you pass strings which do NOT contain replacement variables to the NLS#bind methods also?
Another translatability issue was also also found in the org.eclipse.tptp.test.tools.manual plug-in (see http://www.eclipse.org/tptp/home/downloads/CHKPII.php?version=4.5.0&buildID=TPTP-4.5.0-200804020832), as noted under defect 218779.
(In reply to comment #2) > According to the JavaDoc for the NLS class, the NLS#bind methods perform string > substitution and should be considered a convenience for MessageFormat#format > method calls. The same single quote handling based on the criteria should still > be used. > > Do you pass strings which do NOT contain replacement variables to the NLS#bind > methods also? > Thanks Kit. I was mistaken and I should have read my own comment at the top of the message.properties file: # NOTE: When using substitution parameters, all single quote characters (e.g. ') must be escaped with a preceding single quote character (e.g. ''text in single quotes''). This string does not have any substitution parameters, so it should contain single quotes.
Hours worked for the patch.
Created attachment 94689 [details] Patch
Patch checked in to CVS (HEAD).
Closing by default since not closed by the originator in the 7+ months since being resolved. Please reopen if the issue is still present in the latest TPTP release or the resolution is not correct.
