Community
Participate
Working Groups
Framework admin is mangling the showplash argument and in general is getting it completely wrong. It should not resolve the showsplash path in all cases. Some effort is required during metadata generation to ensure a correct value. 1) If the splash bitmap comes from a feature/plugin, a CU fragment for the splash should probably be generated to get the correct path in the case of bundle pools. 2) If the splash bitmap is coming from the root files then a relative path would be required (which framework admin can relativize). 3) I'm not sure how a absolute path for the bitmap should be handled. See http://wiki.eclipse.org/Equinox_Launcher#Command_line_arguments for an outline of the semantics of the -showplash argument
I have changed framework admin to not do anything to the -showsplash argument. The normal value for eclipse "org.eclipse.platform" will work when the bundle pool in colocated with the install. Still need to generate CUs to contribute the splash screen to the ini properly.
Anything else to do here? Can you update the target milestone if there is more work?
There is more work to do here, but it is too much to make it in 3.4
*** Bug 217740 has been marked as a duplicate of this bug. ***
This bug is back :-). Actually, the publish product work that we did doesn't manage this very well.
Andrew, where did you create the CU for the splash screen in Eclipse 3.4? I can't seem to find anything in the generator for this.
The generator did not do anything for splash screen CUs, it just ignored the whole issue and -showsplash and osgi.splashPath just passed through with any other eclipse.ini or config.ini property.
did this work when the splash screen was in a bundle pool?
Be careful here as, like the initial bug mentioned, there could be something wrong going on in framework admin.
Ok, I see, splash screens don't work with the bundle pool. I just installed Eclipse with the following director command: -console -consolelog -application org.eclipse.equinox.p2.director.app.application -metadataRepository http://download.eclipse.org/eclipse/updates/3.4 -artifactRepository http://download.eclipse.org/eclipse/updates/3.4 -installIU org.eclipse.sdk.ide -destination c:/es/testInstall/ -profile SDKProfile Because no bundle pool is specified, it puts it in the p2 area. When I launched, no splash screen is shown. Should I just mimic this behaviour in 3.5?
Created attachment 125837 [details] Adds default splash screen support to the publisher This patch sets up the splash screen the same way the generator did. This patch should be reviewed and applied, but the bug report should remain open (there is still more work to do). This simply gets us to the same state with the publisher as we were with the generator.
Created attachment 125838 [details] mylyn/context/zip
Created attachment 125847 [details] Updated patch This patch fixes a test case that was failing in the previous patch.
Created attachment 125848 [details] mylyn/context/zip
Comment on attachment 125847 [details] Updated patch patch committed. Thanks. Leaving bug open to deal with the shared install splash problem.
Similar issues exist around the splash when the bundles are not located in the typical area. Closing as dup *** This bug has been marked as a duplicate of bug 274127 ***
