Community
Participate
Working Groups
The Software Updates dialog for p2 is modeless. The intention was to be like a "dashboard" that the user could refer back to. And a bit like the Firefox (and others) add-ons dialog. But if seems to just confuse people. Issues include: - Sometimes it gets lost when I Alt-Tab elsewhere then come back - I was looking for an install progress bar in the dialog and it was in the workbench (bug #218186) - I tried to hit Esc and it didn't work (bug #221744) I don't want to make it modal just to fix the bugs mentioned above, but most of them imply that modality was expected.
I think the difference here is that I can't actually check back on this dialog to monitor the state of ongoing install operations. So, there's currently no value in keeping it open after you've kicked off the install/uninstall/whatever that was initiated from the dialog.
Yes, that suggests if we don't do something per bug #218186 it might make sense to make it modal in 3.4, and reconsider it later.
marking 3.4 as we'll make this decision along with the progress reporting one...
I made it modal/blocking to deal with bugs from launched dialogs, since the event loop is still spinning. This is not necessarily a final decision, so leaving this bug open. Another reason to keep the dialog open is because it is now a drag target.
I had some really odd problems whereby the update/install dialog was not closing on restart, yet the debugger claimed to have terminated the launch. I can't really explain how this could happen, maybe I had an old one from an old launch, not sure. Come to think of it, maybe it was the one in my host workbench and the other one really was closed. The point is, it confused me, and I'm the one who's supposed to understand it. The other problem with the modeless dialog was that the update handler was keeping track of the shell and resurfacing it when the user chooses Help->Software Updates. If there was any failure during the dispose processing in the dialog, then the handler didn't know the dialog was gone, and when the user chose Help->Software Updates, it was trying to set focus to a dead shell. These issues aren't worth sorting through at this stage of the release, and the old UM was modal, so we aren't regressing. So I'm now crawling back into my hole and keeping this modal like everything else in Eclipse (sigh) until I can sort out the issues.
This bug will be addressed in M3 as part of the new workflows
This bug is no longer valid in light of bug #236740
