Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 221652 - [Patch] Widgets layout on Advanced Options page in the Create Patch wizard
Summary: [Patch] Widgets layout on Advanced Options page in the Create Patch wizard
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 trivial (vote)
Target Milestone: 3.6 M1   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-06 07:58 EST by Tomasz Zarna CLA
Modified: 2018-05-02 08:32 EDT (History)
2 users (show)

See Also:

Attachments
Screen shot (19.22 KB, image/png)
2008-03-06 08:04 EST, Tomasz Zarna CLA 		no flags Details
Patch to use the same amount of vertical spacing in both groups. (1.86 KB, patch)
2008-03-07 18:42 EST, Remy Suen CLA 		tomasz.zarna: iplog+
Details | Diff
Remy's patch updated (946 bytes, patch)
2009-07-17 09:58 EDT, Tomasz Zarna CLA 		no flags Details | Diff
mylyn/context/zip (2.93 KB, application/octet-stream)
2009-07-17 09:58 EDT, Tomasz Zarna CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2008-03-06 07:58:25 EST 
Radio buttons in the "Diff Output Format" group are laid out differently then in the "Patch Root" group. See the incoming screen shot.
Comment 1 Tomasz Zarna CLA 2008-03-06 08:04:32 EST 
Created attachment 91753 [details]
Screen shot
Comment 2 Remy Suen CLA 2008-03-06 12:13:47 EST 
I can provide a patch for this. Does Compare want the buttons to have horizontal spacing (like 'Patch Root') or no horizontal spacing (like 'Diff Output Format').
Comment 3 Remy Suen CLA 2008-03-06 12:15:06 EST 
Er, I mean vertical spacing.
Comment 4 Tomasz Zarna CLA 2008-03-07 08:33:30 EST 
I think there is enough space to have it (ie I would add the spacing for "Diff Output Format" group). Thanks in advance Remy.
Comment 5 Remy Suen CLA 2008-03-07 18:42:47 EST 
Created attachment 91944 [details]
Patch to use the same amount of vertical spacing in both groups.
Comment 6 Tomasz Zarna CLA 2009-07-17 09:55:22 EDT 
Sorry for the late response Remy. Let me look at the patch...
Comment 7 Tomasz Zarna CLA 2009-07-17 09:58:11 EDT 
Created attachment 141888 [details]
Remy's patch updated

Needed to update your patch to apply it cleanly (it is over 1 year old), other then that works like a charm.
Comment 8 Tomasz Zarna CLA 2009-07-17 09:58:13 EDT 
Created attachment 141889 [details]
mylyn/context/zip
Comment 9 Tomasz Zarna CLA 2009-07-17 10:01:45 EDT 
Released to HEAD, available in builds >N20090716-2000. Thanks Remy!