Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 220733 - Missing Theme after using browsers back button
Summary: Missing Theme after using browsers back button
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.0   Edit
Hardware: PC All
: P3 trivial (vote)
Target Milestone: 1.3 M2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-28 07:20 EST by Magnus Konze CLA
Modified: 2009-09-17 12:14 EDT (History)
2 users (show)

See Also:

Attachments
Proposed fix (1.51 KB, patch)
2009-09-16 05:18 EDT, Vasko Tchoumatchenko CLA 		no flags Details | Diff
Alternative fix (1.17 KB, patch)
2009-09-16 17:05 EDT, Vasko Tchoumatchenko CLA 		ruediger.herrmann: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Magnus Konze CLA 2008-02-28 07:20:02 EST 
Build ID: I20070625-1500

Steps To Reproduce:
1. Start application, theme appears correctly.
2. Go to another website.
3. Return to the application using the browsers back button -> Theme is missing.


More information:
Problem appears with standalone RAP (1.1 M2)
Comment 1 Vasko Tchoumatchenko CLA 2009-09-16 05:18:11 EDT 
Created attachment 147284 [details]
Proposed fix

The proposed patch restores the "org.eclipse.rap.theme.current" attribute after a   session restart.
Comment 2 Vasko Tchoumatchenko CLA 2009-09-16 17:05:44 EDT 
Created attachment 147379 [details]
Alternative fix

The patch adds "no-store" directive to the Cache-Control header of the rwt-index.html, therefore instructing the client not to store the page in the local history. When the RAP page is re-visited by navigating the browser's history, a new GET request for the page URL will be issued. This request triggers the "browser survey" mechanism and the correct branding is be set.

For a lengthy discussion why "no-store" is required by Firefox (and apparently Chrome) see this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=139541

The proposed fix is tested with FF 3.5.3, Chrome 3, Safari 4 and IE 8 on WinXP.
Comment 3 Rüdiger Herrmann CLA 2009-09-17 11:12:35 EDT 
Applied patch #2. Changes are in CVS HEAD.