Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 22071 - [Editor Mgmt] Graphical hint for pinned editor
Summary: [Editor Mgmt] Graphical hint for pinned editor
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.0 RC2   Edit
Assignee: Hanna Farah CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-07-31 06:20 EDT by Jörg von Frantzius CLA
Modified: 2004-06-04 21:44 EDT (History)
2 users (show)

See Also:

Attachments
Adds a pin icon when pinning editors (14.77 KB, patch)
2004-05-28 18:10 EDT, Hanna Farah CLA 		no flags Details | Diff
Adds a pin icon when pinning editors and handles the pin editor keyboard shortcut (17.85 KB, patch)
2004-06-02 11:03 EDT, Hanna Farah CLA 		no flags Details | Diff
Implements the "equals" method for ImageWrapper and OverlayIcon (2.18 KB, patch)
2004-06-02 18:06 EDT, Hanna Farah CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jörg von Frantzius CLA 2002-07-31 06:20:15 EDT 
It would be nice if a pinned editor window would have some graphical decorator
so that one immediately sees that it is pinned.
Comment 1 Adam Kiezun CLA 2003-10-17 12:25:56 EDT 
decorating the icon in the tab should be easy to do, i think
Comment 2 Adam Kiezun CLA 2003-10-17 12:27:13 EDT 
btw, it would also allow you to get rid of the slightly strangely placed 'pin
editor' toolbar button.
Comment 3 Michael Van Meekeren CLA 2004-05-20 22:16:20 EDT 
verified the images are now in build I200405201600
Comment 4 Michael Van Meekeren CLA 2004-05-21 09:28:38 EDT 
images are found in 
org.eclipse.ui\icons\full\ovr16\pinned_ovr.gif
AND

org.eclipse.ui.ide\icons\full\ovr16\pinned_ovr.gif
Comment 5 Ines Khelifi CLA 2004-05-21 09:30:33 EDT 
Verified with build id: 200405210800 on Windows XP for both projects.
Comment 6 Ines Khelifi CLA 2004-05-21 09:40:46 EDT 
Verified with build id: 200405210800 on Mac OS 10.3.3 for both projects.
Comment 7 Hanna Farah CLA 2004-05-28 18:10:09 EDT 
Created attachment 11299 [details]
Adds a pin icon when pinning editors

This patch will apply a small pin on top of an editor's original icon, it uses
caching to optimize image creation. It also listens for preference changes and
enables or removes the pins accordingly.
Comment 8 Hanna Farah CLA 2004-06-02 11:03:35 EDT 
Created attachment 11469 [details]
Adds a pin icon when pinning editors and handles the pin editor keyboard shortcut

This patch also includes the code for the pin editor keyboard shortcut, a
handler was added in EditorManager.
Comment 9 Tod Creasey CLA 2004-06-02 14:55:42 EDT 
Modified patch applied for build 20040502
Comment 10 Hanna Farah CLA 2004-06-02 18:06:34 EDT 
Created attachment 11508 [details]
Implements the "equals" method for ImageWrapper and OverlayIcon

Since ImageWrapper and OverlayIcon implement the "hashCode" method, I also
added an implementation for the "equals" method as suggested by Nick and Tod.
Comment 11 Nick Edgar CLA 2004-06-03 13:27:59 EDT 
Patch applied with some changes to use Util.hashCode and Util.equals for
possibly-null fields.
Comment 12 Nick Edgar CLA 2004-06-04 21:44:04 EDT 
Verified that the pin editor decorations works, and that the equals and hashCode
code changes are in I20040604-1600.