Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 220611 - Add PageSwitcher command to the Console View
Summary: Add PageSwitcher command to the Console View
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.4   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: 3.4 M7   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-27 12:24 EST by Paul Webster CLA
Modified: 2008-04-25 16:39 EDT (History)
3 users (show)

See Also:

Attachments
Implementation (5.11 KB, patch)
2008-04-15 10:55 EDT, Markus Keller CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2008-02-27 12:24:13 EST 
org.eclipse.ui.part.PageSwitcher is API that was added in 3.4 to provide setup for the next Page/previous Page command.

The console view could make use of this fairly easily.

PW
Comment 1 Markus Keller CLA 2008-04-15 10:55:34 EDT 
Created attachment 96086 [details]
Implementation

Here's a straightforward implementation.
Comment 2 Michael Rennie CLA 2008-04-15 11:59:56 EDT 
Applied patch, thanks Markus.
Comment 3 Michael Rennie CLA 2008-04-15 12:00:13 EDT 
verified
Comment 4 Darin Wright CLA 2008-04-23 09:35:03 EDT 
Re-opening, when I set up a key binding, the page switcher will appear in the first console page, but never again once I switch pages.
Comment 5 Michael Rennie CLA 2008-04-23 09:43:21 EDT 
Testing it again, and I could not get the switcher to come at all anymore.
Comment 6 Darin Wright CLA 2008-04-24 13:08:32 EDT 
It appears the key-binding works... but I had it set for the "In Console" context which only applies to "process consoles". As soon as stack trace console is selected, the command no longer works (since it's a different context).

We should really have an "In Console View" context and update the text of the current context to "In Process Console"... or something more descriptive of a standard out/err console. We need the specialized context for the EOF key bindings to work (Ctrl-Z/D).
Comment 7 Darin Wright CLA 2008-04-24 22:52:11 EDT 
Fixed. Added an "In Console View" context to the console plug-in and renamed the existing context to "In I/O Console".
Comment 8 Darin Wright CLA 2008-04-24 22:52:26 EDT 
Please verify, Curtis.
Comment 9 Curtis Windatt CLA 2008-04-25 16:39:39 EDT 
Verified.