Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 220599 - [CommonNavigator] Project Explorer does not support Navigate > Show In...
Summary: [CommonNavigator] Project Explorer does not support Navigate > Show In...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4.1   Edit
Assignee: Francis Upton IV CLA
QA Contact:
URL:
Whiteboard: ready
Keywords:
: 220529 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-02-27 11:31 EST by Anton Leherbauer CLA
Modified: 2009-06-01 09:52 EDT (History)
6 users (show)

See Also:
pwebster: review+

Attachments
Proposed fix (1.18 KB, patch)
2008-02-27 11:34 EST, Anton Leherbauer CLA 		no flags Details | Diff
Proposed fix #2 (2.51 KB, patch)
2008-02-28 02:31 EST, Anton Leherbauer CLA 		francisu: iplog+
Details | Diff
Patch revised for copyright notice (2.79 KB, patch)
2008-08-14 00:44 EDT, Francis Upton IV CLA 		no flags Details | Diff
Revised per Pauls' suggestion (2.79 KB, patch)
2008-08-14 19:37 EDT, Francis Upton IV CLA 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Leherbauer CLA 2008-02-27 11:31:57 EST 
Navigate > Show In... on any selection in the Project Explorer always shows 

  <No Applicable Views> 

even if the PE is registered as showInPart element in a perspectiveExtension. 
The Navigator view at least shows 

  History
  Project Explorer

for the same selection in the Resource perspective.

The reason seems to be that class CommonNavigator is not adaptable to IShowInSource.
Comment 1 Anton Leherbauer CLA 2008-02-27 11:34:51 EST 
Created attachment 90885 [details]
Proposed fix

Make CommonNavigator adaptable to IShowInSource.
Comment 2 Paul Webster CLA 2008-02-27 12:21:49 EST 
BTW: Anton, it looks like you attached a cdt patch instead.

PW
Comment 3 Remy Suen CLA 2008-02-27 15:53:50 EST 
Is this kind of related to bug 218885?
Comment 4 Anton Leherbauer CLA 2008-02-28 02:31:58 EST 
Created attachment 90975 [details]
Proposed fix #2

Sorry. This time it's the right patch.
Comment 5 Anton Leherbauer CLA 2008-02-28 02:35:51 EST 
(In reply to comment #3)
> Is this kind of related to bug 218885?

I don't think so. Bug 218885 is about making the PE a show-in target. This bug is about PE being a show-in source.
Comment 6 Francis Upton IV CLA 2008-08-14 00:44:52 EDT 
Created attachment 109963 [details]
Patch revised for copyright notice

Paul, can you review this for 3.4.1?  I have tested it and it seems to work fine.
Comment 7 Francis Upton IV CLA 2008-08-14 03:17:16 EDT 
*** Bug 218885 has been marked as a duplicate of this bug. ***
Comment 8 Paul Webster CLA 2008-08-14 09:41:54 EDT 
The patch needs a tweak.  getShowInSource() should be private in 3.4.1 (otherwise it is API).  Other than that, it looks good:  When you commit, don't forget to 

1) branch the appropriate projects to the R3_4_maintenance branch (this one applies for bug 170758 as well).

2) increment the minor version of org.eclipse.ui.navigator

3) mark Anton's patch with the iplog flag (in the attachment details section).

PW
Comment 9 Francis Upton IV CLA 2008-08-14 19:37:39 EDT 
Created attachment 110050 [details]
Revised per Pauls' suggestion
Comment 10 Francis Upton IV CLA 2008-08-14 21:48:13 EDT 
Released to HEAD (35M2) and to R3_4_maintenance for 3.4.1
Comment 11 Francis Upton IV CLA 2008-09-01 03:04:26 EDT 
Verified that show in works in M20080827-2000
Comment 12 Anton Leherbauer CLA 2008-09-12 06:33:37 EDT 
*** Bug 220529 has been marked as a duplicate of this bug. ***
Comment 13 John Arthorne CLA 2009-06-01 09:52:15 EDT 
Removing iplog+ from bug - this indicates an IP contribution in a comment
rather than a patch.

http://wiki.eclipse.org/Development_Resources/Automatic_IP_Log