Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 220436 - generalize implementation for generating incoming/outgoing change messages for tooltips and popups
Summary: generalize implementation for generating incoming/outgoing change messages fo...
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 minor (vote)
Target Milestone: 3.0   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 205382 205861
  Show dependency tree
 
Reported: 2008-02-26 14:05 EST by Steffen Pingel CLA
Modified: 2008-06-02 03:11 EDT (History)
2 users (show)

See Also:

Attachments
outdated patch with partial implementation (74.77 KB, patch)
2008-02-26 14:10 EST, Steffen Pingel CLA 		no flags Details | Diff
mylyn/context/zip (188.10 KB, application/octet-stream)
2008-06-02 03:11 EDT, Steffen Pingel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2008-02-26 14:05:59 EST 
The API for generating tooltips and popups to show incoming changes is currently in TasksUiPlugin and has hard coded limits on string length, number of attributes etc. This code should be extracted to a separate class and abstract the presentation from the data model to allow for different presentations and better reuse.
Comment 1 Steffen Pingel CLA 2008-02-26 14:10:37 EST 
Created attachment 90781 [details]
outdated patch with partial implementation
Comment 2 Eugene Kuleshov CLA 2008-04-05 13:50:25 EDT 
Please note that using string limits don't allow efficient use of the available screen real estate because of the non-fixed-width font will have different width depend on the text. So, limits need to be in pixels and text should be cut based on the actual rendered width.
Comment 3 Steffen Pingel CLA 2008-06-02 03:11:31 EDT 
Committed first pass of refactoring the notification implementation. This re-enables notifications and incomings in tooltips for the new API. Notifications are now event based and only displayed for query synchronizations. 

The rendering is still the same. Text is cut off based on string length. Further improvements will be tracked on bug 205861.
Comment 4 Steffen Pingel CLA 2008-06-02 03:11:41 EDT 
Created attachment 103070 [details]
mylyn/context/zip