Community
Participate
Working Groups
Reinstate features and 'empty' plug-ins for as-is components. For the following GA components that were moved to As-Is components in I5, Reinstate the old features and add 'empty' (containing only a manifest file) plug-ins to CVS, build, and packaging: -Perfmon (monitoring agent and statistical views) -Manual Test (test type, runner, and Manual Test View) -BIRT Reports (test, log, trace, and statistical BIRT report generators) Since the As-Is components are periodically built and packaged, the plug-ins will remain intact in CVS and the TPTP builds will have to remove the files from the 'empty' plug-ins (except the manifest file). When existing users of TPTP and consuming products update their TPTP 4.4.1 or below installation to 4.5 using either the Update Manager or downloaded ZIPs, the empty plug-ins will be loaded by Eclipse since they have a newer version number, thereby removing the function from the installation. In TPTP 5.0, the 'empty' plug-ins and associated features will be removed (see bug TBD) since the 'empty' plug-ins will remove the function from 4.5+ updates.
See http://wiki.eclipse.org/4.5_Component_Reorganization for more details.
Alex, please post the list of empty plug-ins and check in the feature changes required for the Perfmon component. You may need to increase the version numbers of the plug-ins/features. I will post the list of empty plug-ins and check in the feature changes required for the remaining components: -Manual Test -BIRT Reports Joel, during the builds and before packaging, we will need to remove everything from the 'empty' plug-ins (except the manifest file).
Alex and I will need to update the installation instructions for the As-Is components.
org.eclipse.hyades.perfmon.agents org.eclipse.hyades.perfmon both part of the feature: org.eclipse.tptp.monitoring and org.eclipse.hyades.statistical.ui part of the features org.eclipse.tptp.platform.runtime org.eclipse.tptp.platform.sdk Note that I reverted the changes for the feature org.eclipse.tptp.platform.sdk, adding the source feature org.eclipse.tptp.platform.statistical.ui.source.
Since the Manual Test tools were previously packaged within existing Test Project plug-ins (org.eclipse.hyades.test.tools.core and org.eclipse.hyades.test.tools.ui), there is no work required for this defect. For the BIRT Reports, the following features/plug-ins are affected: BIRT Test Reports: Plugins: org.eclipse.tptp.test.report.birt org.eclipse.tptp.test.report.birt.ui org.eclipse.tptp.test.report.birt.doc.user Feature: org.eclipse.tptp.test.reports.birt BIRT Log Reports: Plugins: org.eclipse.tptp.monitoring.report.birt org.eclipse.tptp.monitoring.report.birt.ui org.eclipse.tptp.monitoring.report.birt.doc.user Feature: org.eclipse.tptp.monitoring.report.birt BIRT Trace Reports: Plugins: org.eclipse.tptp.trace.report.birt org.eclipse.tptp.trace.report.birt.ui org.eclipse.tptp.trace.report.birt.doc.user Feature: org.eclipse.tptp.trace.report.birt BIRT Statistical Reports: Plugins: org.eclipse.tptp.platform.statistical.report.birt org.eclipse.tptp.platform.statistical.report.birt.ui org.eclipse.tptp.platform.statistical.report.birt.doc.user Feature: org.eclipse.tptp.platform.statistical.report.birt
Please roll back your changes made to plug-ins/features checked in that were removed from the build or provide a complete list containing all features (and contained plug-ins) that should be re-added to the build. The associated changes are failing the build.
The feature org.eclipse.tptp.platform.statistical.ui was reincluded into the features org.eclipse.tptp.platform.runtime, org.eclipse.tptp.platform.sdk. Also the feature org.eclipse.tptp.platform.statistical.ui.source was reincluded into org.eclipse.tptp.platform.sdk. The feautre org.eclipse.hyades.statistical.ui includes the plugin org.eclipse.hyades.statistical.ui and the branding plugin org.eclipse.hyades.statistical.ui. I've also restored the branding org.eclipse.tptp.platform.statistical.ui.
Checked in to CVS (HEAD) the missing files from the emptied BIRT Report UI plug-ins: org.eclipse.tptp.test.report.birt.ui org.eclipse.tptp.monitoring.report.birt.ui org.eclipse.tptp.trace.report.birt.ui org.eclipse.tptp.platform.statistical.report.birt.ui
(In reply to comment #6) > Please roll back your changes made to plug-ins/features checked in that were > removed from the build or provide a complete list containing all features (and > contained plug-ins) that should be re-added to the build. The associated > changes are failing the build. > See comment #5.
Logging hours worked for Paul. There is not need to update the installation instructions for the BIRT Reports since the As-Is components will continue to be built and have the same version number as the empty plug-ins: tptp/test/documents/gettingstarted/BIRT_Test_Reports_Getting_Started.html tptp/test/documents/gettingstarted/BIRT_Trace_Reports_Getting_Started.html tptp/test/documents/gettingstarted/BIRT_Log_Reports_Getting_Started.html tptp/test/documents/gettingstarted/BIRT_Statistical_Reports_Getting_Started.html Transferring to Joel for remaining build-related changes.
(In reply to comment #10) > > Transferring to Joel for remaining build-related changes. > For the TPTP BIRT Reports, this requires adding the features back into the TPTP run-time and SDK packages.
Updated Statistical Data Collection Getting started document.
Transferring to Kendric who handled the manual clean-up of the plug-ins in the TPTP drivers.
Changes have been checked into HEAD. After the AS-IS components have been packaged, the respective birt report plug-ins are emptied to only contain: - plugin.properties - plugin.xml - MANIFEST.MF - about.html Runtime and sdk drivers for TPTP and all individual projects are packaged with these emptied plug-ins.
Verified results in TPTP-4.5.0-200803051459 driver. Resolving as fixed.
The plugin.xml files cannot be packaged with these 'empty' plug-ins since they contain extension point implementations that Eclipse will attempt to load. Please remove the plugin.xml file from the following plug-ins: BIRT Test Reports: org.eclipse.tptp.test.report.birt BIRT Log Reports: org.eclipse.tptp.monitoring.report.birt BIRT Trace Reports: org.eclipse.tptp.trace.report.birt BIRT Statistical Reports: org.eclipse.tptp.platform.statistical.report.birt This defect is required for I6 since it is blocking 225309.
Created attachment 94604 [details] patch Joel, can you please review the patch? Thanks.
Approved by PMC, patch checked into HEAD.
My apologies Kendric, but the same is required as well for the following plug-ins: BIRT Test Reports: org.eclipse.tptp.test.report.birt.doc.user BIRT Log Reports: org.eclipse.tptp.monitoring.report.birt.doc.user BIRT Trace Reports: org.eclipse.tptp.trace.report.birt.doc.user BIRT Statistical Reports: org.eclipse.tptp.platform.statistical.report.birt.doc.user Note, this is not required for I6.
(In reply to comment #19) > Note, this is not required for I6. Unfortunately, I have take back this comment. The run-time ZIPs for the 4.5 I6 candidate do not contain any of the following features/plug-ins: BIRT Test Reports: Plugins: org.eclipse.tptp.test.report.birt org.eclipse.tptp.test.report.birt.ui org.eclipse.tptp.test.report.birt.doc.user Feature: org.eclipse.tptp.test.reports.birt BIRT Log Reports: Plugins: org.eclipse.tptp.monitoring.report.birt org.eclipse.tptp.monitoring.report.birt.ui org.eclipse.tptp.monitoring.report.birt.doc.user Feature: org.eclipse.tptp.monitoring.report.birt BIRT Trace Reports: Plugins: org.eclipse.tptp.trace.report.birt org.eclipse.tptp.trace.report.birt.ui org.eclipse.tptp.trace.report.birt.doc.user Feature: org.eclipse.tptp.trace.report.birt BIRT Statistical Reports: Plugins: org.eclipse.tptp.platform.statistical.report.birt org.eclipse.tptp.platform.statistical.report.birt.ui org.eclipse.tptp.platform.statistical.report.birt.doc.user Feature: org.eclipse.tptp.platform.statistical.report.birt
Created attachment 94995 [details] patch2 Joel, can you review this new patch? Thanks =)
Kendric, Please update the patch to not remove the contents of the source plug-ins which are not contained in the runtime drivers. Also please update the comments to reflect the package being updated (e.g. monitoring runtime instead of monitoring sdk).
Created attachment 95003 [details] modified patch Ok. Above changes have been made incorporated into a new patch.
Verified changes in TPTP-4.5.0-200804031156A. Resolving as fixed.
Verified in TPTP-4.5.0-200806070100. Closing.