This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 219763 - The GraphResponseViewer should not call the Outputter more than once
Summary: The GraphResponseViewer should not call the Outputter more than once
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Cosmos (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Martin D Simmonds CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-21 06:17 EST by Martin D Simmonds CLA
Modified: 2012-01-03 13:47 EST (History)
3 users (show)

See Also:
weitzelm: pmc_approved+

Attachments
Patch to remove multiple calls to Outputter (3.93 KB, patch)
2008-02-21 06:37 EST, Martin D Simmonds CLA 		no flags Details | Diff
Patch to remove multiple calls to Outputter (2.08 KB, patch)
2008-02-21 10:46 EST, Martin D Simmonds CLA 		no flags Details | Diff
Patch the store (2.38 KB, patch)
2008-02-21 11:04 EST, Martin D Simmonds CLA 		dlwhiteman: iplog+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin D Simmonds CLA 2008-02-21 06:17:06 EST 
There are three places in the GraphResponseViewer where the outputter is called.  We only need to do this once as the store is saved in globalParams.store.

The code should be modified to remove the multiple calls and to use the store.
Comment 1 Martin D Simmonds CLA 2008-02-21 06:17:59 EST 
I have a fix for this.  Working now on creating a patch.
Comment 2 Martin D Simmonds CLA 2008-02-21 06:37:24 EST 
Created attachment 90329 [details]
Patch to remove multiple calls to Outputter

The patch created includes Sheldons Patch that adds the Destroy method.  It is a cumulative patch as CVS is frozen now, and Sheldon's atch has not been applied to CVS.
Comment 3 Martin D Simmonds CLA 2008-02-21 10:46:28 EST 
Created attachment 90362 [details]
Patch to remove multiple calls to Outputter

This just contains the patch for this bug and does not include the patch for the destroy method.
Comment 4 Martin D Simmonds CLA 2008-02-21 11:04:26 EST 
Created attachment 90365 [details]
Patch the store

Overides the previous patch where Destroy was included
Comment 5 Martin D Simmonds CLA 2008-02-22 10:25:19 EST 
Removed the code that called the GraphResponseOutputter every time a cell was clickeon on, in the top grid.
Comment 6 Sheldon Lee-Loy CLA 2008-03-05 13:12:30 EST 
verified, closing bug.