This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 219721 - GraphReponseViewer is not properly destroyed
Summary: GraphReponseViewer is not properly destroyed
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Cosmos (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 blocker (vote)
Target Milestone: ---   Edit
Assignee: Sheldon Lee-Loy CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-20 22:44 EST by Sheldon Lee-Loy CLA
Modified: 2012-01-03 13:53 EST (History)
2 users (show)

See Also:
weitzelm: pmc_approved+


Attachments
Patch that has the fix (1.52 KB, patch)
2008-02-20 22:44 EST, Sheldon Lee-Loy CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sheldon Lee-Loy CLA 2008-02-20 22:44:24 EST
1. Submit a cmdbf query to the example MDR
2. Select the query node. 
3. Select the exampe MDR.
4. Reselect the query node.

An exception occurs when trying to recreate the graph response viewer.  The ids are already registered.  The reason is the graph response viewer is not properly destroyed.
Comment 1 Sheldon Lee-Loy CLA 2008-02-20 22:44:46 EST
Created attachment 90279 [details]
Patch that has the fix
Comment 2 Martin D Simmonds CLA 2008-02-21 05:48:36 EST
In my i8 environment where I tested this, I was not seeing this problem for
some reason.  I applied this patch to that environment and it does not behave
as I expect.  The second time that you click on the CMDBfquery leaf you get a
'null has no properties' in firebug, but if you now click on it, you get the
widget created.

I can only imagine that in your environment that you have the query builder in
between, and therefore something different is happening, so that you do not see
this.

What if someone does want to include the GraphResponseViewer, and they do not
have the query builder in between? I suspect it will show what I get.  I am
unclear if this fix fixes all situations or not.
Comment 3 Sheldon Lee-Loy CLA 2008-02-21 08:49:25 EST
(In reply to comment #2)
I'm not sure why you would get 'null has no properties'.  It might be related to another problem.  I'm just destroying the child widgets in the destroy method.   It shouldn't matter if the query builder exists or not as long as the destroy method is called it should clean up the child widgets.
Comment 4 Sheldon Lee-Loy CLA 2008-02-21 12:59:14 EST
(In reply to comment #2)
I went over this issue with Martin and we resolved the issue.  However there may be an issue with the development environment.  This is a separate issue and Martin will open another bug.
Comment 5 Sheldon Lee-Loy CLA 2008-02-21 13:07:06 EST
Applied patch and fixed bug.
Comment 6 Sheldon Lee-Loy CLA 2008-02-27 17:01:09 EST
Verified bug in build COSMOS-1.0.0-200802261616
Comment 7 Sheldon Lee-Loy CLA 2008-03-05 13:12:25 EST
verified, closing bug.