Community
Participate
Working Groups
This is a request to go through all COSMOS features and plugins to ensure the version string includes the .qualifier at the end. I noticed that a bunch of the DC ones and the org.eclipse.cosmos.common one are versioned 1.0.0, which would cause them to just get replaced every build.
David, can you explain the impact in practical terms for me, please? What gets replaced? Does that break anything or is this a "performance of build can be improved" item? I'm asking so that we can choose an iteration to target this to.
The issue is the fact that the file names of plugins for different builds does not change, the way they are currently configured. So if a plugin was called plugin_1.0.jar in i8, it is also called plugin_1.0.jar in i9. Once you install the one for i9, it would replace the i8 version of the file, and you would have no trace of the i8 version on your system in case you needed to revert. You would also have trouble identifying what build the plugin came from. Further, it just makes sense for them to have different names since they have different content. When you include the .qualifier tag in your version string, it gets replaced by the unique number of the build. So you would instead get plugin_1.0_v200802211234.jar for i9, and then perhaps plugin_1.0_v200803135234.jar in i10. It's an easy change to make and helps us stay consistent with our other plugins and Eclipse guidelines.
Based on David's explanation, targeting to i10.
Assigning to Leonard as per Saurabh's/Jack's request.
Created attachment 93418 [details] Patch to add check for existence of .qualifier in version string This patch provides a check in the build for the existence of the .qualifier in the version string.
Following plugins needs to have qualifier in version string. org.eclipse.cosmos.common org.eclipse.cosmos.dc.broker.client org.eclipse.cosmos.dc.dataManager org.eclipse.cosmos.dc.dataManager.client org.eclipse.cosmos.dc.dataManager.common org.eclipse.cosmos.dc.example.mdr.source org.eclipse.cosmos.dc.framework.source org.eclipse.cosmos.dc.logging.datamgr org.eclipse.cosmos.dc.logging.datamgr.client org.eclipse.cosmos.dc.logging.datamgr.common org.eclipse.cosmos.dc.logging.datamgr.source org.eclipse.cosmos.dc.management.domain.client org.eclipse.cosmos.dc.mdr org.eclipse.cosmos.dc.mdr.client org.eclipse.cosmos.dc.mdr.common org.eclipse.cosmos.dc.mdr.registration org.eclipse.cosmos.dc.mdr.registration.client org.eclipse.cosmos.dc.mdr.registration.common org.eclipse.cosmos.dc.source org.eclipse.cosmos.dc.stat.datamgr org.eclipse.cosmos.dc.stat.datamgr.client org.eclipse.cosmos.dc.stat.datamgr.common org.eclipse.cosmos.dc.stat.datamgr.source org.eclipse.cosmos.example.mdr org.eclipse.cosmos.example.mdr.registration org.eclipse.cosmos.example.mdr.web org.eclipse.cosmos.me.dmtoolkit.source org.eclipse.cosmos.me.management.common org.eclipse.cosmos.me.management.source org.eclipse.cosmos.me.management.wsdm org.eclipse.cosmos.rm.sml.mdr org.eclipse.cosmos.rm.source org.eclipse.cosmos.samples.cmdbf.services
Some (but not all) of these have already been fixed now.
Following plugins needs to have qualifier in version string. org.eclipse.cosmos.dc.example.mdr.source org.eclipse.cosmos.dc.framework.source org.eclipse.cosmos.dc.logging.datamgr org.eclipse.cosmos.dc.logging.datamgr.client org.eclipse.cosmos.dc.logging.datamgr.common org.eclipse.cosmos.dc.logging.datamgr.source org.eclipse.cosmos.dc.management.domain.client org.eclipse.cosmos.dc.source org.eclipse.cosmos.dc.stat.datamgr org.eclipse.cosmos.dc.stat.datamgr.client org.eclipse.cosmos.dc.stat.datamgr.common org.eclipse.cosmos.dc.stat.datamgr.source org.eclipse.cosmos.example.mdr org.eclipse.cosmos.example.mdr.registration org.eclipse.cosmos.example.mdr.web org.eclipse.cosmos.me.dmtoolkit.source org.eclipse.cosmos.me.management.common org.eclipse.cosmos.me.management.source org.eclipse.cosmos.me.management.wsdm org.eclipse.cosmos.rm.sml.mdr org.eclipse.cosmos.rm.source org.eclipse.cosmos.samples.cmdbf.services
Created attachment 96063 [details] Patch to ignore .source plugins This patch makes the plugin qualifier check ignore plugins with .source in their name.
Please change the status of this bug. We have script to check the qualifier string in plugin version.
This is now resolved
Saurabh, if this fix was made prior to Leonard earning committer status, it should be marked as IPLog, else it shouldn't.
I think you and I are not applying the iplog flag correctly. I think we need to go into the Details for each attachment and mark them there, rather than doing it for the entire defect.
