Community
Participate
Working Groups
We could get rid of one wizard page by converting the action provide a drop-down that contains each task repository which provides task creation facilities.
Such drop down will look really crowded with my 20 repositories. Maybe you could show the last 5 and also take active working set into the account. I am always using Alt-Shift-N (then Enter in most of the cases). It is faster then toolbar and works when Task List view is not visible.
Yes, I was thinking this would most likely take the active working set into account. Note that this isn't intended to accelerate things for experts but for the average user.
Need to defer: http://wiki.eclipse.org/index.php/Mylyn/3.0_Plan#Deferred_Items
Created attachment 125916 [details] in progress screenshot Here is what the ui is looking like. Since we can't get a single image descriptor for the repo icon and brand overlay in one, I've opted for the branding icon.
This is looking good, but we can't have just the overlay icon because it is too small. Depending on how you are creating the images, there should be some mechanism for you to get a composite image descriptor or image. See TaskElementLabelProvider for examples. Regarding the structure, here's what I think we should go with: ================ Local Eclipse Mozilla Bugzilla ---------- Query Category ---------- Add Task Repository... (make sure you use an existing message since we'll probably change this to New...). ================
Okay thanks Mik, I've now got regular repository icons with branding overlays in the menu (via CompositeImageDescriptor). I'm not sure that Query and Category make sense in this button. I would expect to find these under a separate folderImage+ button.
Created attachment 126098 [details] New Task Dropdown patch Completely functional patch. Works in conjunction with Frank's new product selection code.
Outstanding issues with patch I'm working on (aside from ui changes) * new task in context menu commented out (will put it back) * New task wizard doesn't allow completion after repository selection
Created attachment 126101 [details] update 2 Simplified and addressed outstanding issues mentioned previously.
Committed progress to date. Still need to ensure progress when configuration is retrieved (wasn't already cached locally).
Created attachment 126365 [details] screenshot Completed ui as per comment#5. As per Mylyn conference call, if this become a general 'new' menu dropdown it makes sense that we put them all in there. We may want to revisit the icon at some point.
Fixed order to Create Query, Create Category. Left a separator to single out local repository. If no task repositories exist only a single separator will be visible between local repository and the create query action.
Look great! I have applied a minor tweak to fix up the icon overlay and images sizes.
Created attachment 126370 [details] mylyn/context/zip
I noticed that the list of repositories is empty when a working set has no queries. This is inconsistent with the Task List which shows all queries in that case.
The other thing that is really important is that the product is initialized based on the current selection similar to how this used to work for the Bugzilla product page.
(In reply to comment #15) > I noticed that the list of repositories is empty when a working set has no > queries. This is inconsistent with the Task List which shows all queries in that > case. Fixed. (In reply to comment #16) > The other thing that is really important is that the product is initialized > based on the current selection similar to how this used to work for the Bugzilla > product page. I've been looking into this and the problem I've run up against here is that the TasksUiUtil api accepts a ITaskMapping rather than a ISelection. But at the point of creating a new task now, we don't have connector specific knowledge of how to create a mapping (in the case of a non-task selection). If we were only concerned with task selections this would be straight forward using connector.getTaskMapping(taskData), but we want this to work for queries as well. So I've merged the code to generate the Bugzilla specific mapping into NewBugzillaTaskWizard. Other solutions entail adding api to extract a mapping from a selection.
[..] > I've merged the code to generate the Bugzilla specific mapping into > NewBugzillaTaskWizard. Other solutions entail adding api to extract a mapping > from a selection. Thanks Rob. That is exactly the intended approach with the current API. The new task wizard is the UI component that knows how to create a task mapping from the current workbench state. Is there anything left to do here?
UI review on Mylyn call was positive. Marking resolved.
