Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 219171 - [multi monitor][windows] screenshot feature mis-captures multi-monitor desktop when primary monitor is to the right of the secondary
Summary: [multi monitor][windows] screenshot feature mis-captures multi-monitor deskto...
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 2.2   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.0   Edit
Assignee: Willian Mitsuda CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-15 16:05 EST by Eddie Galvez CLA
Modified: 2008-11-04 21:32 EST (History)
2 users (show)

See Also:


Attachments
screenshot of the attach screenshot dialog (35.10 KB, image/png)
2008-02-15 16:07 EST, Eddie Galvez CLA
no flags Details
screenshot after restart (23.37 KB, image/jpeg)
2008-02-19 08:56 EST, Eddie Galvez CLA
no flags Details
screenshot, eclipse primary monitor web browser secondary (left) (12.18 KB, image/jpeg)
2008-02-19 08:57 EST, Eddie Galvez CLA
no flags Details
proper capture (57.77 KB, image/jpeg)
2008-02-19 09:00 EST, Eddie Galvez CLA
no flags Details
Patch (1.38 KB, patch)
2008-04-18 03:54 EDT, Willian Mitsuda CLA
no flags Details | Diff
mylyn/context/zip (3.43 KB, application/octet-stream)
2008-04-18 03:54 EDT, Willian Mitsuda CLA
no flags Details
Updated patch (1.39 KB, patch)
2008-05-17 17:34 EDT, Willian Mitsuda CLA
no flags Details | Diff
mylyn/context/zip (3.92 KB, application/octet-stream)
2008-05-17 17:34 EDT, Willian Mitsuda CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eddie Galvez CLA 2008-02-15 16:05:49 EST
I just tried the attach screenshot feature against my jira connector task, and when I hit capture desktop I got:

actual desktop:

[ monitor one, secondary, full screen eclipse ] [ monitor two, primary, full screen firefox ]

the captured image ended up being:

[monitor-two'simage][completely white]

I can only speculate that this is because of assumption that the primary is to the left of the secondary, which in this case it is not.
Comment 1 Eddie Galvez CLA 2008-02-15 16:07:25 EST
Created attachment 89885 [details]
screenshot of the attach screenshot dialog

Note the left part of the image; that is actually the application on my RIGHT side, primary monitor (notice the start menu). The right part of the image is completely blank, likely because it tried to capture to the "right of" the primary monitor, but my secondary is to the left of it.
Comment 2 Mik Kersten CLA 2008-02-18 23:59:05 EST
Willian: have you seen this?  I've never had it malfunction this way, but notably my secondary monitor has always been on the right.  

Eddie: does this behavior persist if you restart?  If not, what if you switch the order of your monitors?  I don't have a second monitor plugged in right now to try.  The challenge is that we're using a built-in facility for desktop capture so I'm not sure how easily we'll be able to work around this.
Comment 3 Eddie Galvez CLA 2008-02-19 08:56:12 EST
Created attachment 90060 [details]
screenshot after restart

screenshot taken from attach screenshot button from bug 219171 task editor, in another instance of eclipse.
eclipse left monitor (secondary)
web browser right monitor (primary)
Comment 4 Eddie Galvez CLA 2008-02-19 08:57:35 EST
Created attachment 90061 [details]
screenshot, eclipse primary monitor web browser secondary (left)

i moved eclipse, non maximized, to my right primary monitor, browser now on left secondary. screenshot only captured primary monitor w/ eclipse, secondary not showing.
Comment 5 Eddie Galvez CLA 2008-02-19 08:58:54 EST
I've attached the screenshots, they are all only a portion of it, i cropped the portion that was in the 'middle' of the screenshot each time.

i'll "switch" monitor order now and try again, I almost expect that to work :)
Comment 6 Eddie Galvez CLA 2008-02-19 09:00:25 EST
Created attachment 90062 [details]
proper capture

when i told windows my primary (1) was left-of secondary (2) [even though physically this isnt true], the screenshot now properly captures everything.
Comment 7 Willian Mitsuda CLA 2008-02-19 13:15:17 EST
 (In reply to comment #2)
> Willian: have you seen this?  I've never had it malfunction this way, but
> notably my secondary monitor has always been on the right.

Actually, I use only 1 monitor, although my video card supports 2 outputs.

I'll setup another monitor tonight and make some tests here.
Comment 8 Willian Mitsuda CLA 2008-02-20 20:05:58 EST
This is actually a SWT bug. Opened bug#219716.

Eddie, please post a comment there providing which version of Eclipse you are using.
Comment 9 Mik Kersten CLA 2008-02-26 12:48:57 EST
Willian: thanks for tracking that down!

*** This bug has been marked as a duplicate of bug 219716 ***
Comment 10 Willian Mitsuda CLA 2008-04-18 03:40:12 EDT
Reopening, since this is actually a bug in Mylyn handling multi-monitor capture. Explanation is in bug#219716.

I'll post a patch soon.
Comment 11 Willian Mitsuda CLA 2008-04-18 03:54:47 EDT
Created attachment 96558 [details]
Patch

I actually didn't test this patch because I don't have a second monitor available right now. But this should work according to the explanation from Silenio.

Mik or Eddie: can any of you please verify if this solution works?
Comment 12 Willian Mitsuda CLA 2008-04-18 03:54:49 EDT
Created attachment 96559 [details]
mylyn/context/zip
Comment 13 Mik Kersten CLA 2008-05-05 01:14:27 EDT
Willian: could you please recreate against the new commons.ui project, or just paste in the entire method?
Comment 14 Willian Mitsuda CLA 2008-05-17 17:34:12 EDT
Created attachment 100786 [details]
Updated patch
Comment 15 Willian Mitsuda CLA 2008-05-17 17:34:14 EDT
Created attachment 100787 [details]
mylyn/context/zip
Comment 16 Mik Kersten CLA 2008-05-19 16:04:07 EDT
Patch applied, looks good.  Haven't verified with multi-monitor setup yet.
Comment 17 Eddie Galvez CLA 2008-05-19 16:05:35 EDT
Mik, or others, remind me where your plugins are in source (or point me to the wiki page that has that info?) and I'll try the patch against my multi-monitor setup.
Comment 18 Willian Mitsuda CLA 2008-05-19 17:01:18 EDT
Eddie, you can get all source from HEAD by importing this .psf file:

http://www.eclipse.org/mylyn/doc/dev/mylyn.psf