Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 218722 - [api] move AbstractRepositoryTaskEditor.getHistoryUrl() into AbstractRepositoryConnector
Summary: [api] move AbstractRepositoryTaskEditor.getHistoryUrl() into AbstractReposito...
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.0   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 179254 214134
  Show dependency tree
 
Reported: 2008-02-12 18:51 EST by Eugene Kuleshov CLA
Modified: 2008-03-31 02:17 EDT (History)
0 users

See Also:

Attachments
mylyn/context/zip (3.36 KB, application/octet-stream)
2008-02-12 18:55 EST, Eugene Kuleshov CLA 		no flags Details
mylyn/context/zip (11.91 KB, application/octet-stream)
2008-03-31 02:17 EDT, Steffen Pingel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Kuleshov CLA 2008-02-12 18:51:29 EST 
To enable opening task history right from the task list (bug 214134) and also to provide generic facility for looking up task history url, AbstractRepositoryTaskEditor.getHistoryUrl() need to be moved into AbstractRepositoryConnector.

Let me know if you'd like patch for that.
Comment 1 Eugene Kuleshov CLA 2008-02-12 18:55:30 EST 
Created attachment 89577 [details]
mylyn/context/zip
Comment 2 Mik Kersten CLA 2008-02-13 00:03:32 EST 
I wonder if it would be better on AbstractRepositoryConnectorUi since that's where most of the URL stuff is, and since Web UI based viewing of history is a UI concept?
Comment 3 Eugene Kuleshov CLA 2008-02-13 00:54:17 EST 
(In reply to comment #2)
> I wonder if it would be better on AbstractRepositoryConnectorUi since that's
> where most of the URL stuff is, and since Web UI based viewing of history is a
> UI concept?

You probably used the same reasoning when you put getAccountCreationUrl() and getAccountManagementUrl() into the UI pluging. However all those urls could be also useful for headless tools as well as the UI actions and the url is more like repository-specific metadata rather then something related to UI. The actions that would use those urls in Mylyn would of course live in UI.

Anyways, I don't want to argue about this and if you convinced UI is better place for new getHistoryUrl() call, let's put it into UI, so it would be possible to fix bug 214134.
Comment 4 Steffen Pingel CLA 2008-03-31 02:17:35 EDT 
Added method to AbstractRepositoryConnectorUi: public String getTaskHistoryUrl(TaskRepository taskRepository, String taskKey). Implemented for Bugzilla and JIRA and changed the new AbstractTaskEditorFormPage to use the new method.
Comment 5 Steffen Pingel CLA 2008-03-31 02:17:37 EDT 
Created attachment 94168 [details]
mylyn/context/zip
Comment 6 Steffen Pingel CLA 2008-03-31 02:17:48 EDT 
Marking resolved.