Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 218620 - ILaunchConfigurationVariableSupplier should not use ICdtVariable
Summary: ILaunchConfigurationVariableSupplier should not use ICdtVariable
Status: CLOSED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: Remote Tools (show other bugs)
Version: 2.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Daniel Felix Ferber CLA
QA Contact: Greg Watson CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-12 08:26 EST by Leonardo Garcia CLA
Modified: 2011-01-31 07:51 EST (History)
0 users

See Also:

Attachments
Patch correcting the problem described. (1.77 KB, patch)
2008-02-12 08:31 EST, Leonardo Garcia CLA 		g.watson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leonardo Garcia CLA 2008-02-12 08:26:35 EST 
Build ID: M20071023-1652

Steps To Reproduce:
The ILaunchConfigurationVariableSupplier class is using ICdtVariable as the return value type of its methods. However, ICdtVariable is not available in CDT 3.x and hence this can cause some problems in some scnearios where Remote Tools is needed.

The patch for this problem is fairly simple: we just have to substitute ICdtVariable by IBuildMacro. IBuildMacro exists on CDT 3.x and CDT 4.x. In CDT 4.x, actually, IBuildMacro inherits ICdtVariable.

More information:
Comment 1 Leonardo Garcia CLA 2008-02-12 08:31:33 EST 
Created attachment 89493 [details]
Patch correcting the problem described.
Comment 2 Greg Watson CLA 2008-02-14 13:53:03 EST 
Committed.
Comment 3 Leonardo Garcia CLA 2008-08-21 16:23:07 EDT 
Closing the bug as it is already corrected.