Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 218344 - [Viewers] allow to constomize how colors on selection are rendered
Summary: [Viewers] allow to constomize how colors on selection are rendered
Status: RESOLVED INVALID
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M6   Edit
Assignee: Boris Bokowski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-08 12:19 EST by Martin Aeschlimann CLA
Modified: 2008-03-24 06:53 EDT (History)
2 users (show)

See Also:


Attachments
patch (3.19 KB, patch)
2008-02-08 12:19 EST, Martin Aeschlimann CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Aeschlimann CLA 2008-02-08 12:19:26 EST
Created attachment 89277 [details]
patch

20080208

As a UI guideline, no colors should be rendered on selected element.

But for the JDT 'find occurrence' and the Platform/Search 'text search' result view, we think we should make an exception on this rule.

In these views, the background color is used to mark the matches on the line. Not showing any matches when the line is selected is not a good option, as the match location is the important information.

For selected elements we experimented with different approaches and ended up with using the 'dotted box' for matches in selected element.

I don't think this is established enough to make this the default behavior in the  SimpleStyledCellLabelProvider. Therefor I suggest to open up the SimpleStyledCellLabelProvider so that the paint behavior can be replaced.

See the attached patch for a suggestion.
Comment 1 Boris Bokowski CLA 2008-03-24 02:35:26 EDT
Martin, are you still waiting on this?
Comment 2 Martin Aeschlimann CLA 2008-03-24 06:53:38 EDT
this got fixed by our latest changes