Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 218127 - [CommonNavigator] Common Navigator inherited viewer bindings
Summary: [CommonNavigator] Common Navigator inherited viewer bindings
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.5 M6   Edit
Assignee: Francis Upton IV CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 270008
  Show dependency tree
 
Reported: 2008-02-07 00:43 EST by Chuck Bridgham CLA
Modified: 2009-03-25 14:06 EDT (History)
1 user (show)

See Also:

Attachments
Suggested implementation patch (6.94 KB, patch)
2008-02-07 00:48 EST, Chuck Bridgham CLA 		francisu: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chuck Bridgham CLA 2008-02-07 00:43:25 EST 
This enhancement describes the ability for common navigator viewer instances to "inherit" the action and content bindings from other viewers.
Comment 1 Chuck Bridgham CLA 2008-02-07 00:48:30 EST 
Created attachment 89103 [details]
Suggested implementation patch

This patch contains changes to the naviagtor registry reader to recognize a predefined "option" for viewer inheritance, and register these relationships.

The reader then registers bindings with all child viewers
Comment 2 Francis Upton IV CLA 2009-03-08 11:47:13 EDT 
I took a different approach than your implementation (sorry I can't attach a patch, I put the patch in my clipboard and overwrote it, after I had checked it in).

Anyhow, I added an inheritsBindingsFrom attribute to the viewer element.  It inherits the bindings (both types) and the drag assistants (like your patch), it does not inherit the viewer properties.

It also does not have any way to add bindings in the child viewer, it uses exactly those of the parent.  

If this does not meet your requirements, please open another bug report.

Released to HEAD, I20090308-2000, 35M6
Comment 3 Chuck Bridgham CLA 2009-03-25 13:58:16 EDT 
I have tested, and this is fantastic!!

But..  I really can't use without the ability to extend beyond whats inherited.

I will verify this, but open a separate enhancement... hopefully in time for M7?
Comment 4 Chuck Bridgham CLA 2009-03-25 14:06:28 EDT 
Added https://bugs.eclipse.org/bugs/show_bug.cgi?id=270008