Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 217801 - [CommonNavigator] Capability filtering of commonWizard extensions uses wrong identifier
Summary: [CommonNavigator] Capability filtering of commonWizard extensions uses wrong ...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4.1   Edit
Assignee: Francis Upton IV CLA
QA Contact:
URL:
Whiteboard: ready
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-05 05:03 EST by Anton Leherbauer CLA
Modified: 2008-09-01 03:12 EDT (History)
2 users (show)

See Also:
eclipse: review+

Attachments
Use wizardId as contribution id (1.21 KB, patch)
2008-02-05 05:03 EST, Anton Leherbauer CLA 		francisu: iplog+
Details | Diff
Revised to add test cases (29.12 KB, patch)
2008-08-14 19:41 EDT, Francis Upton IV CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Leherbauer CLA 2008-02-05 05:03:12 EST 
Created attachment 88863 [details]
Use wizardId as contribution id

The fix for capability filtering introduced with bug 156928 in 3.2.1 uses the associatedExtensionId attribute instead of the wizardId to compute the identifier for activity pattern matching.

This is inconsistent with other areas where wizards are capability-filtered.
Comment 1 Francis Upton IV CLA 2008-08-14 00:28:27 EDT 
Kim, you mind reviewing this one for 3.4.1?  I have tested it (and in fact added an automated test for it).
Comment 2 Kim Horne CLA 2008-08-14 11:05:53 EDT 
That looks fine.
Comment 3 Francis Upton IV CLA 2008-08-14 19:41:06 EDT 
Created attachment 110051 [details]
Revised to add test cases
Comment 4 Francis Upton IV CLA 2008-08-14 21:48:23 EDT 
Released to HEAD (35M2) and to R3_4_maintenance for 3.4.1
Comment 5 Francis Upton IV CLA 2008-09-01 03:12:37 EDT 
The test case for this passed in M20080827-2000.