Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 217752 - [logview] provide action to open entry stack trace in console
Summary: [logview] provide action to open entry stack trace in console
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal with 1 vote (vote)
Target Milestone: 3.5 M2   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 235291 240129 241142 (view as bug list)
Depends on: 243139
Blocks:
  Show dependency tree
 
Reported: 2008-02-04 16:06 EST by Jacek Pospychala CLA
Modified: 2008-08-11 11:44 EDT (History)
4 users (show)

See Also:

Attachments
patch (4.86 KB, patch)
2008-08-05 05:23 EDT, Jacek Pospychala CLA 		curtis.windatt.public: iplog+
Details | Diff
icon (941 bytes, image/gif)
2008-08-05 05:26 EDT, Jacek Pospychala CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jacek Pospychala CLA 2008-02-04 16:06:27 EST 
see bug 217644.
Let's go further with Curtis work https://bugs.eclipse.org/bugs/show_bug.cgi?id=217644#c5
Comment 1 Jacek Pospychala CLA 2008-02-04 17:02:43 EST 
see https://bugs.eclipse.org/bugs/show_bug.cgi?id=217644#c12
>- Opening stack trace in Java Stack Trace console require action to be invoked
>from popup menu (arguably less convenient), then previous content of that view
>will be lost. Though this is probably the less intrusive middle ground.
Comment 2 Jacek Pospychala CLA 2008-06-03 05:47:40 EDT 
*** Bug 235291 has been marked as a duplicate of this bug. ***
Comment 3 Curtis Windatt CLA 2008-07-09 09:46:17 EDT 
*** Bug 240129 has been marked as a duplicate of this bug. ***
Comment 4 Curtis Windatt CLA 2008-07-09 09:51:21 EDT 
There is at least some interest in this feature.  This should be looked at again in 3.5.

Remember that a patch with a simple implementation is available on bug 217644.
Comment 5 Jacek Pospychala CLA 2008-07-09 10:15:21 EDT 
I should have some spare time within next couple of days and have some patch with this for you.
Comment 6 Ketan Padegaonkar CLA 2008-07-16 15:25:51 EDT 
*** Bug 241142 has been marked as a duplicate of this bug. ***
Comment 7 Jacek Pospychala CLA 2008-08-05 05:23:48 EDT 
Created attachment 109139 [details]
patch

This is original Curtis patch with two minor changes: externalized strings and "additions" changed to constant. It also uses a new icon (grayed out open_artifact_obj.gif) to indicate whether button is disabled.
Patch contains only PDE part of changes. I'll create a separate bug in JDT-debug for debug part.
Comment 8 Jacek Pospychala CLA 2008-08-05 05:26:51 EDT 
Created attachment 109142 [details]
icon

icon to be put in org.eclipse.pde.ui/icons/obj16/open_artifact_disabled_obj.gif
it's grayed out org.eclipse.pde.ui/icons/obj16/open_artifact_obj.gif
Comment 9 Curtis Windatt CLA 2008-08-05 15:24:04 EDT 
Since the warm up builds for M1 have already started, I'll wait until the start of M2 to put this in.

Thanks for finishing this Jacek.
Comment 10 Curtis Windatt CLA 2008-08-11 11:43:29 EDT 
Comment on attachment 109139 [details]
patch

Marking patch as contributed.  Thanks for your work on this Jacek.
Comment 11 Curtis Windatt CLA 2008-08-11 11:44:53 EDT 
Made some improvements to avoid creating too many instances of the console.  Committed to HEAD.