This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 217488 - Remove Phoenix as a requirement for Babel server
Summary: Remove Phoenix as a requirement for Babel server
Status: RESOLVED FIXED
Alias: None
Product: Babel
Classification: Technology
Component: Server (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Antoine Toulmé CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-01 14:03 EST by Denis Roy CLA
Modified: 2009-01-26 09:44 EST (History)
2 users (show)

See Also:


Attachments
Patch that removes all references to Phoenix (97.92 KB, patch)
2009-01-22 13:08 EST, Antoine Toulmé CLA
no flags Details | Diff
The patch to fix the head links (909 bytes, patch)
2009-01-26 07:59 EST, Antoine Toulmé CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Denis Roy CLA 2008-02-01 14:03:02 EST
Currently Babel server code requires Phoenix, and it shouldn't require it.
Comment 1 Antoine Toulmé CLA 2009-01-21 02:03:06 EST
What's up with this bug ? Mind if I do something about it ?
Comment 2 Denis Roy CLA 2009-01-21 09:04:03 EST
By all means... I'm having a hard time keeping up with everything you're doing anyway, one more thing can't hurt :)
Comment 3 Antoine Toulmé CLA 2009-01-22 10:46:43 EST
I have started working on it. Assigning to myself.

I have removed all dependencies to Phoenix, but the layout is all screwed up. I am now working on the header. Not sure it's worth maintaining with the ongoing changes at eclipse.org.
Comment 4 Antoine Toulmé CLA 2009-01-22 13:08:50 EST
Created attachment 123407 [details]
Patch that removes all references to Phoenix

The attached patch removes the need for Phoenix.
It adds the images that were part of Phoenix.

There is now 1 css file, babel.css, that contains a copy/paste of the Phoenix css files with some refactoring.

The head.php and foot.php files are refactored to be independent. We can refactor them a bit more and make way for them to have hooks.

The website looks as good as before on my dev box. Denis, please try it out.
Comment 5 Antoine Toulmé CLA 2009-01-22 13:09:20 EST
Reassigning to Denis for testing.
Comment 6 Antoine Toulmé CLA 2009-01-23 12:35:57 EST
Reassigning to me. Staging commit...
Comment 7 Antoine Toulmé CLA 2009-01-23 12:36:57 EST
Committed. Now let's run a thorough examination of the UI.

We also need to remove the links on the Babel machine, and change the release and update scripts.
Comment 8 Antoine Toulmé CLA 2009-01-26 07:59:18 EST
Created attachment 123731 [details]
The patch to fix the head links

I found out there were two dead links in the top right portion of the page, for legal and contact. They were kind of assuming a relative URL. I fixed them by adding www.eclipse.org before them.

I will commit that right away.
Comment 9 Antoine Toulmé CLA 2009-01-26 08:04:20 EST
I renamed eclipse.org-common to eclipse.org-common.old on staging/html.

I also checked the scripts, they apparently don't mention eclipse.org-common.

So we should be good. Marking this as fixed. Please reopen if you see something new happening.
Comment 10 Denis Roy CLA 2009-01-26 09:44:29 EST
Awesome!  Thanks!