Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 217440 - Generic recorder wizard forbids customization of the Location page
Summary: Generic recorder wizard forbids customization of the Location page
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P1 normal (vote)
Target Milestone: ---   Edit
Assignee: Paul Slauenwhite CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 208110
  Show dependency tree
 
Reported: 2008-02-01 09:23 EST by Jerome Gout CLA
Modified: 2016-05-05 10:29 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome Gout CLA 2008-02-01 09:23:44 EST 
In the generic recorder wizard, if user selects "Create Test From Existing Recording" rather than "Create Test from New Recording" both next pages (recmodel selection and test suite location page) can not be overriden or customized by clients.

Client is not able to implement a control on test suite location (for instance to avoid the creation of the test suite inside certain projects).

Added pages should be accessible to clients in order to provide their own implementation.
Comment 1 Paul Slauenwhite CLA 2008-02-04 14:02:35 EST 
This is a defect since the GRF was implemented correctly by not supporting this extensibility in one part ("Create Test From Existing
Recording") and supporting it another ("Create Test from New Recording").

Will contain as part of the extensibility work of 208110.
Comment 2 Paul Slauenwhite CLA 2008-03-07 06:24:51 EST 
(In reply to comment #1)
> This is a defect since the GRF was implemented correctly by not supporting this
> extensibility in one part ("Create Test From Existing
> Recording") and supporting it another ("Create Test from New Recording").
> 
> Will contain as part of the extensibility work of 208110.
> 

Correction, was 'not' implemented correctly.
Comment 3 Paul Slauenwhite CLA 2008-03-11 19:16:49 EDT 
Jerome, is it sufficient to allow the user to define their own implementations for pages other than the recmodel selection page when selecting "Create Test From Existing Recording"?  That is, have the recmodel selection page fixed and the user's implementation of the IRecorderPageProvider define the remaining pages for the wizard.
Comment 4 Jerome Gout CLA 2008-03-12 05:22:52 EDT 
Sounds goog to me.
Recmodel selection page seems mandatory, I do agree to let that page as is.

Thanks
Jerome
Comment 5 Paul Slauenwhite CLA 2008-03-13 13:54:19 EDT 
Now, pages contributed by user-defined IRecorderPageProvider implmentations will be added to the GRF wizard, after the RecLocationWizardPage if the user gestured to use an existing recording.

org.eclipse.tptp.test.internal.recorder.ui.wizards.NewTestFromRecordingWizard.java checked into CVS (HEAD).
Comment 6 Paul Slauenwhite CLA 2009-02-25 11:58:41 EST 
Closing by default since not closed by the originator in the 7+ months since
being resolved.  

Please reopen if the issue is still present in the latest TPTP release or the
resolution is not correct.