Community
Participate
Working Groups
The new "Validation Status" dialog that appears during manual validations hang the UI, saying that validation was complete but then only offers a Cancel button to proceed. Validation appears to not have been executed in most cases either when I hit cancel. Recommend that the preference be defaulted to off until this dialog works properly. Even if works properly, the dialog is annoying and seems unnecessary. At very least, it should have a "Don't show this again" checkbox. I'd prefer not to see it all unless I've explicit set the preference.
It doesn't hang the UI, but it is a modal dialog. It is shown at the very end of validation, so once you press cancel, validation is then finished. If it looks like your validator hasn't run, then that would be a different bug. Can you attach a sample, that illustrates this problem. Does it work correctly, if the dialog is turned off? I could add the "Don't show this again" checkbox.
(In reply to comment #1) > It doesn't hang the UI, but it is a modal dialog. It is shown at the very end > of validation, so once you press cancel, validation is then finished. This by itself is a usability issue. "Cancel" means to cancel the current operation. Most users will assume that hitting it cancels something. What you are saying is that it doesn't, it accepts an outcome. So the button should say "Ok" or "Accept". Looking into it further there's another usability issue. If the validation returns problems with a high severity the dialog says that validation "was not successful". This implies that something in the system failed, which is not the case. > If it looks like your validator hasn't run, then that would be a different > bug. I looks like what is happening is that in some cases the validation jobs are run but problem messages are not being updated. Perhaps as a related problem, I am seeing duplicate messages for the same problem cropping up. Attached is an example project.
Created attachment 88836 [details] Example Important the project in the zip. Ignore the two import errors for the tag libraries (you can fix this if you happen to have JSF 1.1 libraries, but it's not essential). Now change either the border or columns attribute value on the h:panelGrid to a value that is not a number (i.e "d"). Manually validate. You should get an error that it's not a valid integer. Now fix it back to "2" and manually validate. I often see the validation marker stay. I often see duplicate validation problems for the same problem, which leads me to wonder if when the manual validation is called with valid value, one or more of the duplicate messages is not being removed. I have verified that the validation *is* actually running using breakpoints, so it seems like the problem is more visual.
Something else I just noticed, when there's duplicates, the type one copy is "JSP Semantics Problem (JSF)", which is the correct one. The other is "Validation Message", which I'm not sure of the source of.
(In reply to comment #3) > Created an attachment (id=88836) [details] Thanks I will investigate.
Created attachment 89083 [details] part 1 of a patch This patches makes some improvements to the dialog. It also removes some (by not all) of the duplicated messages. I am going to keep working on this, but I wanted to get this patch into the system because the as-you-type validation depends on it.
Chuck or Carl could you please commit this patch.
Created attachment 89147 [details] small patch for a missing class Somehow this class got missed as part of the previous patch.
Created attachment 89148 [details] small patch for a missing class Let me try again (without first browsing the settings for the project)
Committed to HEAD for WTP 3.0
Forgot to mark this as fixed when I committed it.
Can this be closed now?
I am in the process of cleaning up the Validation Framework defects. Could you please close this Bugzilla. If I don't hear back within 7 days, I will assume that everything is OK, and will close it.
Verified in 3.0M6.
Thanks - closing.
