Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 216872 - [Discovery] Discovery UI should come with an EP to handle specific services
Summary: [Discovery] Discovery UI should come with an EP to handle specific services
Status: RESOLVED FIXED
Alias: None
Product: ECF
Classification: RT
Component: ecf.ui (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Markus Kuppe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 256603
  Show dependency tree
 
Reported: 2008-01-29 04:13 EST by Markus Kuppe CLA
Modified: 2008-12-12 03:23 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Kuppe CLA 2008-01-29 04:13:51 EST
The discovery UI doesn't offer an EP which allows contribution for specific service handling.
Comment 1 Markus Kuppe CLA 2008-01-29 04:19:53 EST
This bug supports CQ #2038 (https://dev.eclipse.org/ipzilla/show_bug.cgi?id=2038)
Comment 2 Scott Lewis CLA 2008-01-29 11:31:48 EST
I don't understand what is meant by 'service handling'.  There is now the extension point org.eclipse.ecf.discovery.ui.serviceAccessHandler, which allows handlers to be associated with given services that are discovered and shown in UI.

Do you mean some other notion of EP for 'service handling'?

The existing extension point should also certainly be reviewed and if necessary/appropriate changed/generalized as well.  So we can use this bug for that if serviceAccessHandler is close to what you have/had in mind for this bug.

  
Comment 3 Markus Kuppe CLA 2008-01-29 12:40:04 EST
Hi Scott,

I've mainly created this bug to support the CQ for my discovery view contribution. It doesn't correspond to the existing discovery UI. I haven't had a look at org.eclipse.ecf.discovery.ui.serviceAccessHandler yet and it indeed sounds like it fixes this bug. But CQ #2038 goes beyond showing a handler for a given IServiceType. It allows to extend the Tree with your own TreeItems.
Comment 4 Scott Lewis CLA 2008-01-29 12:51:08 EST
(In reply to comment #3)
> Hi Scott,
> 
> I've mainly created this bug to support the CQ for my discovery view
> contribution. It doesn't correspond to the existing discovery UI. I haven't had
> a look at org.eclipse.ecf.discovery.ui.serviceAccessHandler yet and it indeed
> sounds like it fixes this bug. But CQ #2038 goes beyond showing a handler for a
> given IServiceType. It allows to extend the Tree with your own TreeItems.
> 

OK, sounds good.  Actually, I would recommend that we chat/discuss serviceAccessHandler at some point, as I'm not completely satisfied with it (i.e. perhaps it could be made better/clearer)...and if you add an EP to the new discovery UI work it would be good to do something better...but perhaps along the same lines.

BTW, after reading my commments #2 above, I realized that they might have come across as a little terse.  If so, my apologies...I was just on my way out the door.

Comment 5 Markus Kuppe CLA 2008-01-29 12:59:25 EST
(In reply to comment #4)

> OK, sounds good.  Actually, I would recommend that we chat/discuss
> serviceAccessHandler at some point, as I'm not completely satisfied with it
> (i.e. perhaps it could be made better/clearer)...and if you add an EP to the
> new discovery UI work it would be good to do something better...but perhaps
> along the same lines.

OK, what about during next week's ECF conference call?

> BTW, after reading my commments #2 above, I realized that they might have come
> across as a little terse.  If so, my apologies...I was just on my way out the
> door.

Don't worry, no offence taken.
Comment 6 Markus Kuppe CLA 2008-03-05 02:32:16 EST
Moved CQ 2038 (http://dev.eclipse.org/ipzilla/show_bug.cgi?id=2038) to ECF incubation. Keep in mind that this requires EMF >= 2.3.
Comment 7 Markus Kuppe CLA 2008-12-12 03:23:20 EST
Fixed in HEAD