Comment 1 Richard Y.S. HUANG 2008-01-24 06:52:42 EST

Created attachment 87758 [details]
new plug-in project

Comment 2 Richard Y.S. HUANG 2008-01-24 06:53:50 EST

Created attachment 87759 [details]
patch for platform.instrumentation.ui plugin

Comment 3 Richard Y.S. HUANG 2008-01-24 06:56:30 EST

I created two attachments. The zip file is a new plugin project: org.eclipse.tptp.platform.instrumentation.annotation.

The txt file is the patch for current org.eclipse.tptp.platform.instrumentation.ui plugin project.

Comment 4 Eugene Chan 2008-01-24 17:24:57 EST

Hi Richard,

I have shared the new plugin org.eclipse.tptp.platform.instrumentation.annotation on platform module, and update feature file features/org.eclipse.tptp.platform.instrumentation.ui/feature.xml with the new plugin to have it included in the build (I have notified Joel about all these changes)

Moreover, I have applied and checked in the patch of plugin org.eclipse.tptp.platform.instrumentation.ui. Note that I have update the year range of the affected files to 2008. 
*** PLEASE MAKE SURE YOU ALSO UPDATE THE YEAR RANGE TO 2008 ON FILES OF OTHER PLUGIN AFFECTED IN TRACE AND MONITOR PROJECTS ***

You will have to also update the feature file for the other plugins affected in bug 216420 and 194954.

Comment 5 Joel Cayne 2008-01-24 17:28:27 EST

Plug-in added to build.

Comment 6 Richard Y.S. HUANG 2008-01-25 04:34:50 EST

Created attachment 87845 [details]
minor changes for current source code of 194954

Comment 7 Richard Y.S. HUANG 2008-01-25 04:45:13 EST

(In reply to bug 194954 comment #15)
> Richard, I note that your new plugin is 
> Bundle-RequiredExecutionEnvironment: J2SE-1.5
> but plugins that depends on it are 
> Bundle-RequiredExecutionEnvironment: J2SE-1.4
> This sounds like a problem to me.
> 
> Please work with Joel and make sure this won't break the build and use cases.
> 

Eugene, thanks for pointing out this problem. I made some minor changes against the latest code in CVS. I created a new patch, please help review and check in.

I re-opened this defect, and I'll close it after this new patch is checked in and tested.

To Joel, please do remember that org.eclipse.tptp.platform.instrumentation.annotation needs to be built in your separated Java 5 build environment.

Comment 8 Eugene Chan 2008-01-25 09:44:45 EST

(In reply to comment #6)
> Created an attachment (id=87845) [details]
> minor changes for current source code of 194954
> 

Patch is checked into HEAD.

Comment 9 Richard Y.S. HUANG 2008-01-29 21:54:51 EST

Created attachment 88235 [details]
make the dependency to be optional

Comment 10 Joel Cayne 2008-01-30 15:21:12 EST

Patch "make the dependency to be optional" checked into HEAD.

Comment 11 Richard Y.S. HUANG 2008-01-31 22:31:13 EST

code checked into HEAD

Comment 12 Paul Slauenwhite 2009-06-30 12:16:06 EDT

As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.