Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 216053 - Unmatched category does not show incoming icon
Summary: Unmatched category does not show incoming icon
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 2.2   Edit
Hardware: PC Windows Vista
: P3 trivial (vote)
Target Milestone: 2.3   Edit
Assignee: Robert Elves CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-21 16:07 EST by Willian Mitsuda CLA
Modified: 2008-04-10 20:37 EDT (History)
1 user (show)

See Also:

Attachments
Screenshot (7.54 KB, image/jpeg)
2008-01-21 16:08 EST, Willian Mitsuda CLA 		no flags Details
mylyn/context/zip (2.53 KB, application/octet-stream)
2008-01-29 11:42 EST, Robert Elves CLA 		no flags Details
Screenshot (13.46 KB, image/jpeg)
2008-02-05 14:49 EST, Willian Mitsuda CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Willian Mitsuda CLA 2008-01-21 16:07:01 EST 
It looks like the "Unmatched" category does not show the incoming arrow if it has incoming tasks, neither expanded or collapsed.
Comment 1 Willian Mitsuda CLA 2008-01-21 16:08:12 EST 
Created attachment 87443 [details]
Screenshot
Comment 2 Mik Kersten CLA 2008-01-22 17:17:16 EST 
Rob: this is because the UnmatchedContainer class (I just renamed it) doesn't store synchronization state.  For the corresponding rendering code see the landmark in the attached context.
Comment 3 Robert Elves CLA 2008-01-29 11:42:29 EST 
Fixed.
Comment 4 Robert Elves CLA 2008-01-29 11:42:32 EST 
Created attachment 88154 [details]
mylyn/context/zip
Comment 5 Willian Mitsuda CLA 2008-02-04 11:27:54 EST 
Almost fixed. It doesn't work when in focused mode (build I20080203-2200).
Comment 6 Robert Elves CLA 2008-02-05 14:10:23 EST 
This is by design.  All containers in the task list don't reveal incoming state when in focused mode. The reasoning for this was that when in focused mode, tasks with incoming are revealed making the additional incoming on the query redundant.  There was a large design discussion about this on another bug report that escapes me at the moment. Let me know if you would like to read up on it and I will track it down for you.
Comment 7 Willian Mitsuda CLA 2008-02-05 14:48:07 EST 
Well... I have an bugzilla query here that shows the incoming icon when collapsed in focused mode.

Anyway, I particularly don't get why it has to be different in focused mode. It doesn't hurt to be the same as the normal presentation.

If you remember the bug number where there was this discussion, please post here.
Comment 8 Willian Mitsuda CLA 2008-02-05 14:49:52 EST 
Created attachment 88926 [details]
Screenshot
Comment 9 Robert Elves CLA 2008-04-08 20:02:43 EDT 
Mik, do you recall where this conversation took place?
Comment 10 Mik Kersten CLA 2008-04-10 20:37:59 EDT 
We remove them in focused mode because they are redundant when the container is expanded, i.e. you will always see the arrow underneath the query if the query has an incoming.  That's not the case in unfocused mode, where there could be an item that has an incoming filtered.