This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 215732 - Part Title Not Updated On Save As For Javascript File
Summary: Part Title Not Updated On Save As For Javascript File
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Webtools.WST.Javascript (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Nitin Dahyabhai CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-17 18:45 EST by Nick Sandonato CLA
Modified: 2010-03-03 11:34 EST (History)
3 users (show)

See Also:
david_williams: pmc_approved+
thatnitind: pmc_approved? (raghunathan.srinivasan)
thatnitind: pmc_approved? (naci.dai)
thatnitind: pmc_approved? (deboer)
thatnitind: pmc_approved? (neil.hauge)
for.work.things: review+

Attachments
proposed patch (2.02 KB, patch)
2008-01-29 13:19 EST, Nitin Dahyabhai CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Sandonato CLA 2008-01-17 18:45:24 EST 
Build ID: M-2.0.2-20080117053217

Steps To Reproduce:
1. Create a JavaScript file
2. File > Save As...
3. Choose a new name for the file
4. Click OK


More information:
It seems that the content stream for the file, and even the Eclipse window title are updated.  The editor tab title is not updated, however.
Comment 1 Nitin Dahyabhai CLA 2008-01-29 13:19:50 EST 
Created attachment 88164 [details]
proposed patch
Comment 2 Amy Wu CLA 2008-02-12 20:47:11 EST 
fix looks good
Comment 3 Nitin Dahyabhai CLA 2008-02-12 22:32:53 EST 
While this might not appear severe enough for a stop-ship bug, it is one for which there is no workaround and it causes a great deal of confusion when the title does not update properly in this one place.  Not only does the editor have the old title, but because of the way the workbench works, it also appears to the user that they can't open the newly created file in the Javascript editor.  The editor previously followed different code paths when notified that the input or title needed to be changed, one path updating both and the other only updating the input.  This patch changes it so that both will be updated on both changes, provided that there's actually something to update.

Requesting PMC approval.
Comment 4 David Williams CLA 2008-02-12 23:47:14 EST 
It does appear small ... last small bug I approve :)
Comment 5 Nitin Dahyabhai CLA 2008-02-14 01:25:17 EST 
Released.
Comment 6 Nick Sandonato CLA 2008-02-22 15:04:11 EST 
Verified in M-2.0.2RC3-20080221101112
Comment 7 Nitin Dahyabhai CLA 2008-02-23 16:33:27 EST 
Closing