Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 214385 - JSF Semantics validator attempts to validate every resource
Summary: JSF Semantics validator attempts to validate every resource
Status: VERIFIED FIXED
Alias: None
Product: Java Server Faces
Classification: WebTools
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.0 M7   Edit
Assignee: Cameron Bateman CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-04 14:38 EST by Amy Wu CLA
Modified: 2008-05-02 15:08 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Amy Wu CLA 2008-01-04 14:38:35 EST 
using the wtp 3.0 m4 candidate build

The jsf semantics validator attempts to validate every resource (files, folders).  Looking in jsf.core/plugin.xml, it looks like JSFNonELAttributeValueValidator has no filters.  Shouldn't it at least have the same filters as the JSP validators?
Comment 1 Cameron Bateman CLA 2008-01-25 17:41:48 EST 
(In reply to comment #0)
> using the wtp 3.0 m4 candidate build
> The jsf semantics validator attempts to validate every resource (files,
> folders).  Looking in jsf.core/plugin.xml, it looks like
> JSFNonELAttributeValueValidator has no filters.  Shouldn't it at least have the
> same filters as the JSP validators?

Just verified this.  

We were under the impression that the contentTypeBinding option would restrict us to only jsp and jsp fragment files.  Filters based on file extension don't make a lot sense because the user can effectly use anything at runtime that they want; this is especially true as move to view definition metadata other than JSP (this is coming in the JSF 2.0 spec).

As it stands, the validator normally exits immediately if the file being loaded doesn't have a JSP DOM model associated.

I will try and add the facet enabled test though to ensure that it only gets run if the JSF facet is present.
Comment 2 Raghunathan Srinivasan CLA 2008-02-06 18:20:47 EST 
Triaged for 3.0
Comment 3 Cameron Bateman CLA 2008-04-22 17:49:58 EDT 
Issue is fixed.  The validator does a facet check when it is called and returns
immediately if the resource being validated does not belong to a JSF project.
Comment 4 Amy Wu CLA 2008-05-02 15:08:32 EDT 
verified in wtp3.0M7 20080502091049 sdk