Community
Participate
Working Groups
show project keys on project selection page of the new jira task wizard
Created attachment 86128 [details] proposed trivial patch As a value added feature it allow to filter projects using project key
Created attachment 86129 [details] mylyn/context/zip
I find that it makes the selection list look less clear. Would it be possible to use a tool tip instead or a decoration that uses a lighter color for the project key?
Created attachment 86755 [details] screenshot
JIRA web UI does show project keys and one of the main points of proposed patch is to be able to search/filter by these keys. In this case screen real estate permits.
Looks noisy to me too. +1 for a lighter decoration.
(In reply to comment #6) > Looks noisy to me too. > +1 for a lighter decoration. Please suggest how "lighter decoration" would address quick filtering by project key?
Shouldn't it be possible to implement quick filtering by project key entirely independent of any decorations?
(In reply to comment #8) > Shouldn't it be possible to implement quick filtering by project key entirely > independent of any decorations? Anything is possible, but I don't think it really worth to spend time on that, because dialog is not really crowded and proposed approach does provide very handy feature at less development cost. We could still add some separators to the label, maybe put key text into the brackets or something.
Created attachment 88727 [details] filtering Committed fix to take project key into account as been suggested. Also fixed issue with default focus when entering jira project page. While it resolved immediate need for filtering by project key it somewhat confusing that filter doesn't visually match result entries (see attached screenshot). Also note that in JIRA, project keys are meaningfull and it is important to see them because they give additional information (unlike for Bugzilla and Trac) and there is enough screen real estate to show those keys. I am not completely sure what been meant by "lightweight decorators", but I've spent considerable time looking at options for showing decoration in different color and haven't been able find simple solution. Apparently, colored decorations introduced in 3.4 views are all internal in JDT. That leaves only option to use custom drawn tree label, which I believe would be an overkill and somewhat fragile for this particular wizard page. So I am asking to reconsider decision about showing project keys using regular decoration. It can be adjusted to use colors when common Platfrom API will have support for that.
Created attachment 89601 [details] project keys with parenthesis Here are two variants of the project key decoration: - first one has keys drawn in different color using custom paint classes, copied from search.ui and jdt.ui plugins (~300 lines of code). - second is plain text without color decorations The first one look nicer but I am not sure it justify to copy that code. Maybe we should lobby to make these classes API.
The first one is definitely prettier but the second one looks okay, too. Is it possible to have the decoration classes factored out so they can be reused? It could be a good candidate for the the Mylyn cross-projects UI plug-in (bug 214379).
(In reply to comment #12) > Is it possible to have the decoration classes factored out so they can be reused? > It could be a good candidate for the the Mylyn cross-projects UI plug-in (bug > 214379). Like I said, I didn't wrote those classes, just copied them from internal package org.eclipse.search.internal.ui.text and apparently, there are already at least 2 identical copies of those classes in Platform's internal packages. Second one is at org.eclipse.jdt.internal.ui.viewsupport. JDT copy is added in March 2007 and search in July 2007. Anyways, I've committed fix for the second variant.
Just my 2 cents as a pure user: The current implementation with the project key in parentheses (without coloring) looks perfectly OK to me. Thanks, Jörg
I also agree that current UI is sufficient and does the work. Steffen, do you think there is anything else need to be done here or should I resolve this issue?
Go ahead and mark it as resolved. I would prefer to draw the keys in a lighter color but I don't think it's worth investing the effort given that there is no public platform API for that. It might be worth filing a bug against JDT so we would be able to use it in the future.
(In reply to comment #16) > Go ahead and mark it as resolved. Ok > I would prefer to draw the keys in a lighter > color but I don't think it's worth investing the effort given that there is no > public platform API for that. It might be worth filing a bug against JDT so we > would be able to use it in the future. Effort already been invested and I do have working code for the lightweight decoration based on a copy of the code from JDT/Search UI. Apparently there is an experimental SimpleStyledCellLabelProvider API class introduced in 3.4, but javadoc says it is a subject to change and it will also mean it is not going to work on 3.3
