Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 214105 - [Patch] Enablement of "OK" button on the Save Patch dialog
Summary: [Patch] Enablement of "OK" button on the Save Patch dialog
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 trivial (vote)
Target Milestone: 3.5 M1   Edit
Assignee: Pawel Pogorzelski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-02 08:15 EST by Tomasz Zarna CLA
Modified: 2009-06-02 06:49 EDT (History)
0 users

See Also:

Attachments
Patch (3.44 KB, patch)
2008-07-16 07:40 EDT, Pawel Pogorzelski CLA 		no flags Details | Diff
Patch (3.43 KB, patch)
2008-07-16 10:08 EDT, Pawel Pogorzelski CLA 		pawel.pogorzelski1: iplog+
Details | Diff
Patch v03 (4.02 KB, patch)
2008-07-17 05:33 EDT, Tomasz Zarna CLA 		no flags Details | Diff
mylyn/context/zip (10.96 KB, application/octet-stream)
2008-07-17 05:33 EDT, Tomasz Zarna CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2008-01-02 08:15:37 EST 
Steps to reproduce:
1. Modify a shared project
2. Create a patch
3. Select "Workspace" as the location of the patch
4. Click "Browse..."
5. The "Save Patch" dialog shows up
 * Click "OK" - you'll get an error message ("Please enter a file name"). The button should be disabled from the start
 * Enter an invalid name for the patch file, and click "OK" - a different message will appear and the button will be still enabled
Comment 1 Pawel Pogorzelski CLA 2008-07-16 07:40:25 EDT 
The problem was caused by not hooking the validation method to the event handler. I created a patch that should fix the problem. Tomasz, could you have a look at it?
Comment 2 Pawel Pogorzelski CLA 2008-07-16 07:40:52 EDT 
Created attachment 107591 [details]
Patch
Comment 3 Tomasz Zarna CLA 2008-07-16 10:06:11 EDT 
I would embed disabling the OK button in validateFileName() method.
Comment 4 Pawel Pogorzelski CLA 2008-07-16 10:08:29 EDT 
Created attachment 107615 [details]
Patch
Comment 5 Tomasz Zarna CLA 2008-07-17 05:33:14 EDT 
Created attachment 107711 [details]
Patch v03

Here is your patch with some minor modifications. How does it look?
Comment 6 Tomasz Zarna CLA 2008-07-17 05:33:18 EDT 
Created attachment 107712 [details]
mylyn/context/zip
Comment 7 Pawel Pogorzelski CLA 2008-07-17 05:46:38 EDT 
Looks fine, thanks for the change.
Comment 8 Tomasz Zarna CLA 2008-07-17 06:05:20 EDT 
The latest patch released to HEAD. Thanks Pawel.