Community
Participate
Working Groups
See https://bugs.eclipse.org/bugs/show_bug.cgi?id=203158 for guidelines and more information.
Assigning to Hung's team to look at for Sybase enablement projects
It is critical for this defect to be addressed before releasing DTP 1.6. Is this work still planned for M6? Please let me know as soon as possible.
Samuel, I know you're working on 204752 & 204628 to provide much more features for Sybase ASA & ASE databases. Do you plan to fix this bug together?
Created attachment 93352 [details] patch for bug213390 213391 and 216487 patch for bug213390 213391 and 216487
Have some serious issues with this patch... #1, it's huge... #2, it isn't a patch against what is currently in the Eclipse CVS repository. #3, you need to attach the icons separately, as they don't come through in the attachment (binary files don't work that way in CVS attachments). Can you break this thing up into different pieces and make sure it's against what's currently in the Sybase enablement projects in the Eclipse CVS repository?
Created attachment 93518 [details] patch_for_org.eclipse.datatools.enablement.sybase.asa.dbdefinition patch_for_org.eclipse.datatools.enablement.sybase.asa.dbdefinition
Created attachment 93519 [details] patch_for_org.eclipse.datatools.enablement.sybase.asa.models patch_for_org.eclipse.datatools.enablement.sybase.asa.models
Created attachment 93520 [details] patch_for_org.eclipse.datatools.enablement.sybase.asa.ui patch_for_org.eclipse.datatools.enablement.sybase.asa.ui
Created attachment 93521 [details] patch_for_org.eclipse.datatools.enablement.sybase.asa patch_for_org.eclipse.datatools.enablement.sybase.asa
Created attachment 93522 [details] patch_for_org.eclipse.datatools.enablement.sybase.ase.dbdefinition patch_for_org.eclipse.datatools.enablement.sybase.ase.dbdefinition
Created attachment 93523 [details] patch_for_org.eclipse.datatools.enablement.sybase.ase.models patch_for_org.eclipse.datatools.enablement.sybase.ase.models
Created attachment 93524 [details] patch_for_org.eclipse.datatools.enablement.sybase.ase.ui patch_for_org.eclipse.datatools.enablement.sybase.ase.ui
Created attachment 93525 [details] patch_for_org.eclipse.datatools.enablement.sybase.ase patch_for_org.eclipse.datatools.enablement.sybase.ase
Created attachment 93526 [details] patch_for_org.eclipse.datatools.enablement.sybase patch_for_org.eclipse.datatools.enablement.sybase
This looks good guys. I look forward to seeing it delivered into CVS. Then we can massage the enablement map file to make sure these plug-ins are built as part of the nightly build.
This has been delivered and verified. John is manipulating the enablement feature definitions to remove the old ase.profile plug-in. We moved the "Other Driver" driver templates into the *.asa and *.ase plug-ins and will track individual issues as new BZ entries. Great work. This will show up in the M6 build.
The plug-ins org.eclipse.datatools.enablement.sybase.asa and org.eclipse.datatools.enablement.sybase still have UI dependencies.
Ok. We can work that out. The good thing is that the plug-ins are now split out so we can finish off some of that refactoring process. I noticed that we also need to split out the connection profile extension into multiple pieces -- some in the non-ui plugin and some in the ui plugin. We can get this taken care of in the M7 timeframe for sure.
Created attachment 97725 [details] patch for org.eclipse.datatools.enablement.sybase patch
Created attachment 97726 [details] patch for org.eclipse.datatools.enablement.sybase.asa/ase patch
Created attachment 97727 [details] patch for org.eclipse.datatools.enablement.sybase.models
Created attachment 97728 [details] patch for org.eclipse.datatools.enablement.sybas.ui
Ok. After doing some massaging to the patches, I've delivered everything and updated the feature so that all of these. I will be creating a critical bug and assigning it to Lin to fix whatever's gone horribly wrong with populating the tree for ASA & ASE, since now we're throwing Class Cast Exceptions all over the place.
Larry, can you take a look to see if this fixes the remaining issues you had with the UI/non-UI separation? Based on my tests and looking at the plug-ins after Lin's patches, which I have delivered, I think it meets the requirement.
(In reply to comment #23) > Ok. After doing some massaging to the patches, I've delivered everything and > updated the feature so that all of these. I will be creating a critical bug and > assigning it to Lin to fix whatever's gone horribly wrong with populating the > tree for ASA & ASE, since now we're throwing Class Cast Exceptions all over the > place. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=229212, I fix this class cast bug here.
FYI. I'm unable to review any of the attached patches. They display as random characters(looks like binary.) If you are saying these patches have been delivered then there are many problems in HEAD as follows: org.eclipse.datatools.enablement.sybase - ui (depends on org.eclipse.datatools.sqltools.editor.core) org.eclipse.datatools.enablement.sybase.asa - ui (depends on org.eclipse.datatools.sqltools.editor.core) org.eclipse.datatools.enablement.sybase.asa.models - ui - (depends on org.eclipse.datatools.enablement.sybase which depends on org.eclipse.datatools.sqltools.editor.core) org.eclipse.datatools.enablement.sybase.ase - ui (multiple ui dependencies) org.eclipse.datatools.enablement.sybase.ase.models - ui - (depends on org.eclipse.datatools.enablement.sybase which depends on org.eclipse.datatools.sqltools.editor.core)
is there a reason that o.e.d.e.sybase can't have o.e.d.sqtools.editor.core as a dependency?
o.e.d.sqtools.editor.core has massive UI dependencies. So if any of those plug-ins I listed are supposed to be non-ui then they cannot depend on o.e.d.sqtools.editor.core.
Lin, we're close... But as Larry points out below, we have big problems depending on o.e.d.sqtools.editor.core, as it has massive UI dependencies. So if there's code that depends on o.e.d.sqltools.editor.core (like in o.e.d.e.sybase, o.e.d.e.sybase.asa, o.e.d.e.sybase.ase, and so on) we need to move that to the UI plug-ins so there are NO UI dependencies on non-UI plug-ins -- org.eclipse.datatools.enablement.sybase - ui (depends on org.eclipse.datatools.sqltools.editor.core) org.eclipse.datatools.enablement.sybase.asa - ui (depends on org.eclipse.datatools.sqltools.editor.core) org.eclipse.datatools.enablement.sybase.asa.models - ui - (depends on org.eclipse.datatools.enablement.sybase which depends on org.eclipse.datatools.sqltools.editor.core) org.eclipse.datatools.enablement.sybase.ase - ui (multiple ui dependencies) org.eclipse.datatools.enablement.sybase.ase.models - ui - (depends on org.eclipse.datatools.enablement.sybase which depends on org.eclipse.datatools.sqltools.editor.core) Please take another pass at reorganizing to remove this last major UI dependency and then I think we should be good to go. This MUST take priorty so we can have this done for the M7/RC0 milestone.
Because of the increased risk of delivering further changes to address this ui/non-ui refactoring, we are moving this to the RC1 release and changing it back to critical.
Refactoring SQL Dev Tools into UI & non-UI plug-ins will have to wait until the next major release. Unfortunately this bumps this to future
Delivered.
