This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 212962 - [api][working sets] renamed query is dropped from non-active task working sets
Summary: [api][working sets] renamed query is dropped from non-active task working sets
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 3.0   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 221628
Blocks:
  Show dependency tree
 
Reported: 2007-12-13 21:45 EST by Eugene Kuleshov CLA
Modified: 2008-05-09 16:00 EDT (History)
2 users (show)

See Also:

Attachments
mylyn/context/zip (6.44 KB, application/octet-stream)
2007-12-18 21:26 EST, Steffen Pingel CLA 		no flags Details
work in progress (43.32 KB, patch)
2008-05-08 13:59 EDT, Steffen Pingel CLA 		no flags Details | Diff
mylyn/context/zip (15.49 KB, application/octet-stream)
2008-05-08 13:59 EDT, Steffen Pingel CLA 		no flags Details
patch (58.62 KB, patch)
2008-05-08 20:14 EDT, Steffen Pingel CLA 		no flags Details | Diff
mylyn/context/zip (48.84 KB, application/octet-stream)
2008-05-08 20:14 EDT, Steffen Pingel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Kuleshov CLA 2007-12-13 21:45:21 EST 
renamed query is dropped from the task working set
Comment 1 Mik Kersten CLA 2007-12-13 23:14:37 EST 
Steffen: did you make changes here?  I had this working previously.  Have not verified the failure.
Comment 2 Steffen Pingel CLA 2007-12-14 00:59:45 EST 
Not that I know of. I haven't touched the working set code.
Comment 3 Mik Kersten CLA 2007-12-18 20:22:43 EST 
Steffen: could you please investigate?  I can try to get to it later tonight if this isn't high enough on your stack.
Comment 4 Steffen Pingel CLA 2007-12-18 20:56:38 EST 
Will take a look now.
Comment 5 Steffen Pingel CLA 2007-12-18 21:26:15 EST 
I have committed a (failing) test.

The query uses the description as the handle. If that changes it is dropped from the working set. Technically each edit of query removes and re-adds it to the task list so I am not sure how it would be possible to track a change of the description with the current API. Ideas?
Comment 6 Steffen Pingel CLA 2007-12-18 21:26:17 EST 
Created attachment 85512 [details]
mylyn/context/zip
Comment 7 Steffen Pingel CLA 2007-12-18 21:31:00 EST 
If you edit a query while having working set active renaming works since the query is re-added to the working set right away. This will require API changes, deferring to 2.3.
Comment 8 Eugene Kuleshov CLA 2007-12-18 21:44:16 EST 
Just to clarify, it will be re-added only to the active working set. If that query been used in some other inactive working sets, it is most probably going to be dropped from those.
Comment 9 Steffen Pingel CLA 2008-01-28 16:29:48 EST 
Pushing off to 3.0 as this will require API changes.
Comment 10 Steffen Pingel CLA 2008-04-28 19:23:21 EDT 
Rob, reassigning to you since this is related to separating the handle from the query name.
Comment 11 Steffen Pingel CLA 2008-05-08 13:59:47 EDT 
Created attachment 99341 [details]
work in progress
Comment 12 Steffen Pingel CLA 2008-05-08 13:59:50 EDT 
Created attachment 99342 [details]
mylyn/context/zip
Comment 13 Steffen Pingel CLA 2008-05-08 20:14:18 EDT 
Created attachment 99401 [details]
patch
Comment 14 Steffen Pingel CLA 2008-05-08 20:14:24 EDT 
Created attachment 99402 [details]
mylyn/context/zip
Comment 15 Steffen Pingel CLA 2008-05-09 16:00:05 EDT 
Fixed for JIRA by separating handle and summary. Renaming queries will start working for other connectors  when they are ported to the new task list model.