This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 212953 - depends on field in task editor should fill available horizontal space
Summary: depends on field in task editor should fill available horizontal space
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 trivial (vote)
Target Milestone: 2.3   Edit
Assignee: Eugene Kuleshov CLA
QA Contact: Robert Elves CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 158921
  Show dependency tree
 
Reported: 2007-12-13 17:50 EST by Eugene Kuleshov CLA
Modified: 2008-02-06 21:33 EST (History)
1 user (show)

See Also:

Attachments
issue with "depends on" field (16.61 KB, image/png)
2007-12-13 17:51 EST, Eugene Kuleshov CLA 		no flags Details
proposed patch (1.97 KB, patch)
2007-12-13 18:20 EST, Eugene Kuleshov CLA 		no flags Details | Diff
mylyn/context/zip (1.33 KB, application/octet-stream)
2007-12-13 18:21 EST, Eugene Kuleshov CLA 		no flags Details
same ui after the patch (17.11 KB, image/png)
2007-12-13 18:24 EST, Eugene Kuleshov CLA 		no flags Details
task editor for bug 211072 (100.91 KB, image/jpeg)
2008-01-25 18:26 EST, Eugene Kuleshov CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Kuleshov CLA 2007-12-13 17:50:41 EST 
depends on field in task editor should fill available horizontal space
Comment 1 Eugene Kuleshov CLA 2007-12-13 17:51:50 EST 
Created attachment 85229 [details]
issue with "depends on" field
Comment 2 Steffen Pingel CLA 2007-12-13 18:07:54 EST 
We'll need to do some work on the editor layout for the next release cycle.
Comment 3 Eugene Kuleshov CLA 2007-12-13 18:14:31 EST 
Related to bug 151450 and bug 167866
Comment 4 Eugene Kuleshov CLA 2007-12-13 18:20:55 EST 
Created attachment 85230 [details]
proposed patch

Here is proposed patch that makes depends on field fill in available space.

There is a more fundamental problem though. The hyperlink list below "depends on" field is using Composite with RowLayout, however the RowLayout don't play well with scrollable form. In other words, elements in the Composite are never wrapped, and instead always increase form width, making horizontal scrollbar appear on the form. I think it will be better to convert "depends on" and "blocks" field into the SourceViewer and use special hyperlink detector right in the text field (i.e. with Ctrl modifier). See some discussion about this on bug 167866
Comment 5 Eugene Kuleshov CLA 2007-12-13 18:21:00 EST 
Created attachment 85231 [details]
mylyn/context/zip
Comment 6 Eugene Kuleshov CLA 2007-12-13 18:24:03 EST 
Created attachment 85232 [details]
same ui after the patch
Comment 7 Mik Kersten CLA 2007-12-17 23:39:14 EST 
Rob: this may be superseded by your other editor work, since we are planning to make the subtasks UI more explicit.  Since this is a trivial change you can consider making it now.

Eugene: as you know, we still cannot apply your patches.  For the time being, please suggest implementation approaches before providing patches.
Comment 8 Eugene Kuleshov CLA 2008-01-25 18:26:47 EST 
Created attachment 87922 [details]
task editor for bug 211072

Is there anything prevents from applying patch submitted for this issue?

Ideally it would be nice to remove the second line and perhaps use wrapped text area that would allow to see all issues without bowing up the task editor width.
Comment 9 Mik Kersten CLA 2008-01-29 01:28:20 EST 
Rob: you can go ahead and apply once things gets priority.
Comment 10 Robert Elves CLA 2008-02-06 21:07:36 EST 
Patch applied.
Comment 11 Robert Elves CLA 2008-02-06 21:08:02 EST 
Fixed.
Comment 12 Eugene Kuleshov CLA 2008-02-06 21:33:27 EST 
Thanks Rob.