Description Sergey Kuksenko 2007-12-11 11:02:02 EST

Build ID: 3.3

Steps To Reproduce:
Goto Eclipse Unit Tests. 
class - org.eclipse.ui.tests.api.IWorkingSetTest.
Test - "testSetName()"
And change code of testSetName() to the following:
/* added lines has comments */

public void testSetName() throws Throwable {
  /* get workingSetManager */
 IWorkingSetManager workingSetManager = 
                 fWorkbench.getWorkingSetManager();

 /* check that initially workingSetManager
                       contains "fWorkingSet" */
 assertTrue(ArrayUtil.equals(
         new IWorkingSet[] {  fWorkingSet },
         workingSetManager.getWorkingSets()));

 /* remove "fWorkingSet" from working set manager */
 workingSetManager.removeWorkingSet(fWorkingSet);

 /* check that "fWorkingSet" was removed */
 assertTrue(ArrayUtil.equals(new IWorkingSet[] {},
                workingSetManager.getWorkingSets()));
 /* restore state */       
 workingSetManager.addWorkingSet(fWorkingSet);

 /* original code of "testSetName" is started */
 boolean exceptionThrown = false;
 try {
     fWorkingSet.setName(null);
 } catch (RuntimeException exception) {
     exceptionThrown = true;
 }
 assertTrue(exceptionThrown);
 fWorkingSet.setName(WORKING_SET_NAME_2);
 assertEquals(WORKING_SET_NAME_2, fWorkingSet.getName());

 fWorkingSet.setName("");
 assertEquals("", fWorkingSet.getName());

 fWorkingSet.setName(" ");
 assertEquals(" ", fWorkingSet.getName());
 /* original code of "testSetName" is ended */
 
 /* check that workingSetManager contains "fWorkingSet";
             this line should pass correctly */
 assertTrue(ArrayUtil.equals(
         new IWorkingSet[] {  fWorkingSet },
         workingSetManager.getWorkingSets()));

 /* remove "fWorkingSet" from working set manager */
 workingSetManager.removeWorkingSet(fWorkingSet);

 /* check that "fWorkingSet" was removed; 
    BUT! Here you will get assert, because of after 
    renaiming WorkingSet CAN'T be removed */
 assertTrue(ArrayUtil.equals(new IWorkingSet[] {},
                workingSetManager.getWorkingSets()));
  /* restore state */       
  workingSetManager.addWorkingSet(fWorkingSet);
}

I've got failures of the modified unit test on BEA 1.5 and SUN 1.6.

More information:
WorkingSetManager stores all working sets in java.util.SortedSet (java.util.TreeSet) using WorkingSetComparator for ordering.
WorkingSetComparator determine order of WorkingSet using labels and names of working sets.
If WorkingSet.setName() (or setLabel()) methods are called and name (or label) was changed then this actions change ordering of working sets. If at this moment working set was stored in TreeSet - the full ordering logic of TreeSet is broken.

Possible solutions:

1. implements comparator which based on unchangable properties of WS.

2. Complicate logic of setName( and setLabel):
   - remove WS from all TreeSets where it is stored;
   - only after that it is safe to change name/label;
   - add WS back to TreeSets where it was.