Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 212348 - [prov] [repo] Find a way to better report the failure of repository addition
Summary: [prov] [repo] Find a way to better report the failure of repository addition
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Incubator (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M5   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 204186 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-12-09 16:02 EST by Pascal Rapicault CLA
Modified: 2008-01-11 14:46 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Rapicault CLA 2007-12-09 16:02:39 EST 
The addition of an artifact repository results in an error dialog that is rather scary and also lacks details. 
From a UI point of view, we may want to give a less scary error message
From a core point of view, we may want to be more precise about the error message returned. For example, we may want to distinguish from an error contacting the host, a bug while parsing the file, the absence of a known repo file, etc.
Comment 1 John Arthorne CLA 2007-12-10 10:22:19 EST 
I agree. We'll need to add a throws clause to the createRepository and loadRepository methods to be able to pass back failure details. I'll take this.
Comment 2 Susan McCourt CLA 2007-12-10 11:09:04 EST 
The UI issues are covered in bug #204184 and bug #209520 so marking this as a duplicate.  I'm copying the specific info about kinds of errors into bug #209520.

*** This bug has been marked as a duplicate of bug 204184 ***
Comment 3 Susan McCourt CLA 2007-12-10 11:11:38 EST 
sorry, reopening....I didn't see John's comment...
Comment 4 John Arthorne CLA 2007-12-10 14:44:39 EST 
*** Bug 204186 has been marked as a duplicate of this bug. ***
Comment 5 Susan McCourt CLA 2007-12-11 11:41:06 EST 
retitling so this won't appear in my searches.  The UI parts are covered elsewhere.
Comment 6 Susan McCourt CLA 2008-01-08 12:42:34 EST 
We really need a good answer for this before integrating into the SDK or we'll be annoying users with error dialogs and/or silently logging important problems.  Failure to load a repo because the user is disconnected is entirely different than a bogus repo, and there's not a good way currently for the UI to figure out what to do.
Comment 7 John Arthorne CLA 2008-01-08 15:55:44 EST 
Yep, this one's on my list to do in the next week.
Comment 8 Susan McCourt CLA 2008-01-11 11:05:59 EST 
John, when you are looking at this can you also take a look at bug #211102?
Comment 9 John Arthorne CLA 2008-01-11 11:50:42 EST 
I have released the API and implementation changes on the metadata repository side. The create.. and load... methods can no longer return null. The exception provides a user-readable message describing why it failed to load.  I have also changed the create... method to throw an exception in the case where a repository already exists. Previously the spec said it returned null in this case, but it actually returned the existing repository. It's more logical that create will fail if the repository already exists.

Susan, there will likely be some work on your side to surface these exceptions in the UI where appropriate. Currently all exceptions are just logged so the user isn't any wiser.
Comment 10 Susan McCourt CLA 2008-01-11 12:55:12 EST 
Thanks...bug #204184 covers the UI side of this, I'll be looking at this during M5.
Comment 11 John Arthorne CLA 2008-01-11 14:46:36 EST 
The same changes have now been made on the artifact repository side