This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 212211 - source annotations are not painting in source editors (again)
Summary: source annotations are not painting in source editors (again)
Status: CLOSED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.sse (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 critical (vote)
Target Milestone: 3.0 M4   Edit
Assignee: Amy Wu CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-06 17:27 EST by Amy Wu CLA
Modified: 2007-12-07 11:32 EST (History)
1 user (show)

See Also:

Attachments
org.eclipse.wst.sse.ui.patch (1.14 KB, patch)
2007-12-06 19:47 EST, Amy Wu CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Amy Wu CLA 2007-12-06 17:27:24 EST 
source annotations are no longer painting in the source editors again with this newest version of eclipse.

i'm guessing the band-aid that was added in bug 206913 no longer works.
Comment 1 Amy Wu CLA 2007-12-06 19:47:05 EST 
Created attachment 84691 [details]
org.eclipse.wst.sse.ui.patch

Actually, the band-aid still works.  But apparently a new drawing strategy was created to handle drawing problem underlines.  So all we need to do (for now) is just make the same fix we made in bug 206913 and short circuit the viewer decoration support to use the old annotation painter instead of the new problem underliner.

It's just 2 lines of code:
// dont use new problem underline painter
painter.addTextStyleStrategy(AnnotationPreference.STYLE_PROBLEM_UNDERLINE, null);
// use old one
painter.addDrawingStrategy(AnnotationPreference.STYLE_PROBLEM_UNDERLINE, new AnnotationPainter.SquigglesStrategy());
Comment 2 Amy Wu CLA 2007-12-07 02:33:07 EST 
fix released to this week's ibuild
Comment 3 Nitin Dahyabhai CLA 2007-12-07 05:21:50 EST 
Verified with I20071207063230
Comment 4 Amy Wu CLA 2007-12-07 11:32:16 EST 
closing