Comment 1 Guy Pelletier 2008-08-26 10:33:13 EDT

Since BUG 229821 was fixed for 1.0.1 and was a partial fix to this bug I am moving this bug into the 1.1 bucket.

Comment 2 Guy Pelletier 2008-08-27 09:31:45 EDT

Created attachment 111067 [details]
Proposed changes

Comment 3 Guy Pelletier 2008-08-27 10:47:37 EDT

Created attachment 111076 [details]
Updated patch after review from Tom Ware and Peter Krogh

Removing the xml configuration of a generated value on a version field.

Comment 4 Karen Butzke 2008-08-27 10:51:48 EDT

Guy, which mappings support sequencing in eclipselink?  In JPA, I was under the
impression it was only Id mappings.  I am confused as to what is supported in
eclipselink in 1.0 and now with this feature in 1.1

Comment 5 Guy Pelletier 2008-08-27 11:00:30 EDT

JPA allowed sequencing on ID fields only. However, with the fix for bug 229821 in 1.0.1, we opened up the sequencing to non id fields, configurable only via annotations. We did not change the eclipselink-orm.xml in 1.0.1 and the JPA orm does not allow for that configuration/functionality either.

The 1.0.1 fix therefore was a part fix for this bug which would allow the same configurations via xml.

Comment 6 Karen Butzke 2008-08-27 11:07:22 EDT

So, sequencing is now supported on every mapping type in EclipseLink?  Or just on id and embedded-id mapping types?

Comment 7 Guy Pelletier 2008-08-27 11:11:27 EDT

No, only on Id and Basics. Note: An EmbeddedId contains Basics therefore it's now possible to have sequencing on part of the embedded id.

Comment 8 Guy Pelletier 2008-08-27 13:12:34 EDT

Changes have been submitted.

Reviewed by: Tom Ware

New tests: Existing test AggregatePrimaryKeyTest modified to verify the fix (via annotations) and model was copied to the xml package to  be included in the extended testing.

Comment 9 Eclipse Webmaster 2022-06-09 10:25:12 EDT

The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink