Community
Participate
Working Groups
As per conference call the following improvements were suggested: - fail silently when running a background operation (e.g. sync) - add repository decoration to password dialog to make it identifiable as a Mylyn dialog - add a link for opening repository properties from password dialog
Created attachment 88252 [details] new pwd dialog
Created attachment 88253 [details] mylyn/context/zip
I have attached a screenshot of the new password dialog. The repository URL is a hyperlink that opens the repository properties dialog. The "Disconnect Repository" button puts the repository in offline mode and cancels the dialog. Disabling of password prompting for background operations can be considered along with improving cancellation support for 3.0. Mik, could you provide a more Mylynish icon for the wizard title?
Created attachment 88499 [details] wizard banner
Thanks! That image is great.
Committed image. The "Disconnect Repository" button is now only show if the repository is in "online" mode.
This is probably subjective, but here are few observations about the UI. Disconnect repository on that dialog is somewhat breaking regular user interaction. It is not obvious from the UI if it is just an action after which user would need to close dialog using regular cancel or ok button, or "disconnect" button will actually close the UI. Maybe hyperlink or a checkbox would be better for this purpose. Also, from the accessibility point of view it would be a good idea to show repository type in a plain text and not only repository icon (btw, icon might be better go into the dialog icon). I think space permits.
Thoughts: * The task repository looks a bit weird not being a field, because it looks like part of the lable. But not a big deal. * Remove the "Disconnect" button and instead but in a hyperlink that opens the Task Repositories view and a prompt along the lines of: "You can also disconnect this repository via the <link>Task Repositories</link> view. This interrupts workflow too but I believe that it is a better tradeoff and teaches the user how to disconnect/reconnect.
Created attachment 88855 [details] password dialog mockup Here are 3 screenshots for comparison: - cvs password dialog - current mylyn dialog (I've marked things that could be improved in red) - draft mockup of suggested improvements (primarily around repository row, please ignore the difference in font styles) I can work on a pach for implementing proposed mockup if it makes sense.
As per discussion on the conference call: - Keep the a lightweight password dialog that links to the heavy weight repository settings - Change the title to "JIRA Repository Authentication" - Link to repository properties by moving the link to the bottom of the dialog "Open Repository Properties" - Make the UI consistent with the repository properties dialog
Created attachment 89075 [details] next iteration
Created attachment 89076 [details] disconnected check box in repository properties The "Status" section is only expanded if the repository is disconnected.
Committed changes to CVS.
That look much better. Few comments though: - I thought that it been decided on the conf. call to make password prompt look alike with repository properties dialog, i.e. use same layout to show server url and label, but use read-only widgets. - Horizontal indentation for repository icon, user/password label, save password checkbox and "open properties" message need to be made the same. Vertical indentation for "open properties" message look too big (will probably look better if reduced in half) - Hyperlink to "Repository Properties" should not include word "Open" (compare it with similar links in Platform prefs. pages). - There is inconsistent terminology used for that repository properties page. Menu is called "Properties", but dialog title says "Task Repository Settings" (compare with project or VCS properties dialogs, that all use titles like "Properties for XXX"). - The new foldable section on repository settings dialog seem odd and it would take less screen real estate without the foldable section.
(In reply to comment #14) > - I thought that it been decided on the conf. call to make password prompt look > alike with repository properties dialog, i.e. use same layout to show server url > and label, but use read-only widgets. I wasn't sure what the final decision was on the call and made the changes suggested in your screenshot. I think adding read-only widgets for URL and label will take away some of the simplicity of the dialog without any benefit. > - Horizontal indentation for repository icon, user/password label, save password > checkbox and "open properties" message need to be made the same. Vertical > indentation for "open properties" message look too big (will probably look > better if reduced in half) The horizontal indentation is consistent with the rest of the platform (e.g. CVS properties dialog). I agree that the vertical spacing could be reduced. I'll look into that. > - Hyperlink to "Repository Properties" should not include word "Open" (compare > it with similar links in Platform prefs. pages). Unlike in the preferences dialog the link does not just switch to a different page but triggers an action that closes the current dialog. I think that using a verb in the hyperlink text makes that more clear. It is similar to Java -> Compiler -> "Configure Project Specific Settings". > - There is inconsistent terminology used for that repository properties page. > Menu is called "Properties", but dialog title says "Task Repository Settings" > (compare with project or VCS properties dialogs, that all use titles like > "Properties for XXX"). I agree that this should be made consistent. > - The new foldable section on repository settings dialog seem odd and it would > take less screen real estate without the foldable section. My feeling is that disconnected is an advanced feature and used infrequently and should therefore be hidden by default. I would also like to add text that explains what disconnect means which would then justify the additional expandable section.
Created attachment 89100 [details] layout tweaks
Password prompting is currently broken when an operation is launched from a (wizard) dialog.
This will require new API to determine if an operation is running in the background.
Done. All background synchronization jobs now flag progress monitors when running as a background job (i.e. not forced / user initiated). Connectors can use Policy.isBackgroundMonitor() to check if an operation is running in the background. TaskRepositoryLocationUi uses that API to not show the password dialog for background operations.
Created attachment 95612 [details] mylyn/context/zip
