This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 210263 - Missing copyright tool gives false positives for feature & license files
Summary: Missing copyright tool gives false positives for feature & license files
Status: VERIFIED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Cosmos (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P1 critical (vote)
Target Milestone: ---   Edit
Assignee: Jagmit CLA
QA Contact: Balan Subramanian CLA
URL:
Whiteboard:
Keywords:
: 215410 (view as bug list)
Depends on:
Blocks: 216591
  Show dependency tree
 
Reported: 2007-11-19 10:48 EST by David Whiteman CLA
Modified: 2012-01-03 13:48 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Whiteman CLA 2007-11-19 10:48:58 EST
I was looking at the missing copyright report: http://download.eclipse.org/technology/cosmos/1.0.0/COSMOS-1.0.0-200711141637/BadOrMissingCopyrights

The license.html, epl-v10.html, and about.html are being reported as bad/missing copyrights.  This is incorrect information as these files require no (additional) copyright info.  The copyright tool needs to be fixed to either ignore these files, or to do a better job of detecting non-compliance with copyright standards.
Comment 1 Jagmit CLA 2008-01-03 21:12:03 EST
Have changed the logic in the cosmos build (COSMOS-1.0.0-200801031600). Can you verify, if that is correct. 
Comment 2 Jagmit CLA 2008-01-04 10:29:35 EST
can you verify it
Comment 3 David Whiteman CLA 2008-01-04 14:30:33 EST
In the list "Files missing copyright statements", it flags all the html files in the doc plugin.  For example, the file plugins/org.eclipse.cosmos.rm.doc.user/html/resources.html is listed.  Here is the header section of that file:

<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="copyright" content="(C) Copyright IBM Corporation 2007" />
<meta name="DC.rights.owner" content="(C) Copyright IBM Corporation 2007" />
<meta name="security" content="public" />
<meta name="Robots" content="index,follow" />
<meta http-equiv="PICS-Label" content='(PICS-1.1 "http://www.icra.org/ratingsv02.html" l gen true r (cz 1 lz 1 nz 1 oz 1 vz 1) "http://www.rsac.org/ratingsv01.html" l gen true r (n 0 s 0 v 0 l 0) "http://www.classify.org/safesurf/" l gen true r (SS~~000 1))' />
<meta name="DC.Type" content="reference" />
<meta name="DC.Title" content="Resources" />
<meta name="abstract" content="Resources are available for using SML-IF." />
<meta name="description" content="Resources are available for using SML-IF." />
<meta name="DC.Format" content="XHTML" />
<meta name="DC.Identifier" content="resources" />
<meta name="DC.Language" content="en-us" />
<!-- All rights reserved. Licensed Materials Property of IBM -->
<!-- US Government Users Restricted Rights -->
<!-- Use, duplication or disclosure restricted by -->
<!-- GSA ADP Schedule Contract with IBM Corp. -->
<link rel="stylesheet" type="text/css" href="infocenter.css" />
<title>Resources</title>
</head>

Perhaps you can adjust the logic to look for the <meta name="copyright"... stuff.

 
Comment 4 Hubert Leung CLA 2008-01-23 16:13:28 EST
*** Bug 215410 has been marked as a duplicate of this bug. ***
Comment 5 Hubert Leung CLA 2008-01-23 16:15:05 EST
There were many issues introduced while fixing this bug.  Re-targeting to i9 to address to problems.  

Description of a duplicate bug (Bug 215410)
The copyright checking step is temporarily removed from the build because it's
execution totally irrevant and incorrect logic.  The problem was introduced
when fixing 210263.  (Version 1.6 of the copyright-check.sh)

Please correct this file and re-enable the copyright checking.


Comment 6 Jagmit CLA 2008-02-19 16:50:14 EST
fixed this in latest COSMOS build (COSMOS-1.0.0-200802191328). Please verify.
Comment 7 Jagmit CLA 2008-02-20 07:40:03 EST
Marking this as fixed.
Comment 8 David Whiteman CLA 2008-02-20 12:36:16 EST
I have verified that the tool output is accurate.