Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 209725 - [ThreadProf] Data model extending for Thread Profiler needs
Summary: [ThreadProf] Data model extending for Thread Profiler needs
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P1 major (vote)
Target Milestone: ---   Edit
Assignee: Alexander N. Alexeev CLA
QA Contact:
URL: http://www.eclipse.org/tptp/groups/Ar...
Whiteboard: closed460
Keywords:
Depends on:
Blocks: 200320
  Show dependency tree
 
Reported: 2007-11-13 18:01 EST by Alexander N. Alexeev CLA
Modified: 2016-05-05 10:43 EDT (History)
7 users (show)

See Also:
sluiman: review+


Attachments
Proposed model in trace.ecore (91.55 KB, application/octet-stream)
2008-03-03 14:07 EST, Alexander N. Alexeev CLA
no flags Details
Loaders for new trace XML messages (39.07 KB, patch)
2008-03-04 15:50 EST, Alexander N. Alexeev CLA
no flags Details | Diff
updated model (91.55 KB, application/octet-stream)
2008-03-04 15:52 EST, Alexander N. Alexeev CLA
no flags Details
Loaders for new trace XML messages (45.65 KB, patch)
2008-03-04 16:10 EST, Alexander N. Alexeev CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander N. Alexeev CLA 2007-11-13 18:01:09 EST
For contention analysis and CP construction some changes in model is required
- Adding loaders and containers for new Events
- Add computation of monitors ownership transfer
Comment 1 Paul Slauenwhite CLA 2007-11-22 12:53:11 EST
Note, if this enhancement is a work item of 200320, it should be marked as a defect.  Otherwise (e.g. new function not covered by 200320), you will have to request AG and PMC/PG approval to include them in 4.5.
Comment 2 Paul Slauenwhite CLA 2007-11-26 14:08:07 EST
(In reply to comment #1)
> Note, if this enhancement is a work item of 200320, it should be marked as a
> defect.  Otherwise (e.g. new function not covered by 200320), you will have to
> request AG and PMC/PG approval to include them in 4.5.
> 

This was originally opened as an enhancement.
Comment 3 Alexander N. Alexeev CLA 2008-02-05 06:06:16 EST
FDD updated, please review
Comment 4 Alexander N. Alexeev CLA 2008-03-03 14:07:01 EST
Created attachment 91417 [details]
Proposed model in trace.ecore 

Harm, could you take a look on proposed model. It is comply with FDD for Bug 200320.
If it is generally Ok with you we can arrange model regeneration and commit it in CVS.
It is required of further progress on enhancement.

Thanks,
Alex.
Comment 5 Alexander N. Alexeev CLA 2008-03-04 15:50:43 EST
Created attachment 91567 [details]
Loaders for new trace XML messages
Comment 6 Alexander N. Alexeev CLA 2008-03-04 15:52:10 EST
Created attachment 91568 [details]
updated model
Comment 7 Alexander N. Alexeev CLA 2008-03-04 16:10:19 EST
Created attachment 91572 [details]
Loaders for new trace XML messages

Copyright notices added
Comment 8 Harm Sluiman CLA 2008-03-06 14:19:51 EST
(In reply to comment #4)
> Created an attachment (id=91417) [details]
> Proposed model in trace.ecore 
> 
> Harm, could you take a look on proposed model. It is comply with FDD for Bug
> 200320.
> If it is generally Ok with you we can arrange model regeneration and commit it
> in CVS.
> It is required of further progress on enhancement.
> 
> Thanks,
> Alex.
> 

Sorry for the delays. Yes, let's get these changes in. I would like Eugene to be in the loop and begin review the changes as they go in as well. (model and loaders)

My delay was due to our general intent to get back to having the model source actually be in a UML model until we have an alternative way to create the ecore files. But this can not hold up progress.

One design point I was struggling with was the approach of just adding "events" to the model rather than resolving them at event load time into more direct data. For example having a thread object that has creation and start/stop times we have, and  complimenting it with histories/lists of times certain things happened seems a bit smaller to store than a sequential list of the more or less raw events from the agent. However it seems the model was already partially down this path and you simply followed the pattern that was already there...

My reaosn for worrying about this was A) concern about the size impact on the model B) because the other views we have in the profiler can not exploit this data. For example the trace based thread interaction UML view should be able to render most of the thread interaction information, but we are not populating that part of the trace model with the events. I think we need to look at this more going forward because in the end our users will get confused. I can already hear the question of why the "thread interaction" diagram is not available for thread analysis.
Comment 9 Harm Sluiman CLA 2008-03-11 08:36:55 EDT
sorry , I added the comments and did nto check the vote button
Comment 10 Alexander N. Alexeev CLA 2008-03-11 14:20:11 EDT
(In reply to comment #9)
> sorry , I added the comments and did nto check the vote button
> 
Thank you Harm. 
So if you don't mind tomorrow I will regenerate whole model and commit it in CVS with new loaders.
 
Thanks,
Alex.
Comment 11 Harm Sluiman CLA 2008-03-11 14:24:55 EDT
(In reply to comment #10)
> (In reply to comment #9)
> > sorry , I added the comments and did nto check the vote button
> > 
> Thank you Harm. 
> So if you don't mind tomorrow I will regenerate whole model and commit it in
> CVS with new loaders.
> 
> Thanks,
> Alex.
> 

go for it, but as recommended in the document Alex wrote, be sure to compare closely ;-) and use the level correct level of EMF to do the gen.
Comment 12 Alexander N. Alexeev CLA 2008-03-12 11:48:44 EDT
Model regenerated and committed to the HEAD with loaders
Comment 13 Alexander N. Alexeev CLA 2008-03-16 09:43:46 EDT
tested in dev build 
Comment 14 Paul Slauenwhite CLA 2009-06-30 13:48:20 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.
Comment 15 Paul Slauenwhite CLA 2009-06-30 13:48:21 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.