Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 209293 - [useradmin] need an event adapter
Summary: [useradmin] need an event adapter
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Compendium (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M4   Edit
Assignee: Thomas Watson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 202278
Blocks:
  Show dependency tree
 
Reported: 2007-11-08 22:38 EST by Chris Aniszczyk CLA
Modified: 2007-11-13 09:15 EST (History)
2 users (show)

See Also:

Attachments
org.eclipse.equinox.useradmin.patch (168.58 KB, patch)
2007-11-09 11:41 EST, Chris Aniszczyk CLA 		no flags Details | Diff
org.eclipse.equinox.useradmin.patch (9.46 KB, patch)
2007-11-09 16:58 EST, Chris Aniszczyk CLA 		no flags Details | Diff
patch (18.33 KB, patch)
2007-11-12 16:05 EST, Thomas Watson CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Aniszczyk CLA 2007-11-08 22:38:39 EST 
In bug 202278, we removed the respective event adapter for user admin. This event adapter belongs in the actual user admin implementation.
Comment 1 Chris Aniszczyk CLA 2007-11-09 11:41:20 EST 
Created attachment 82546 [details]
org.eclipse.equinox.useradmin.patch

I refactored user admin to be more compliant with how we do things in Eclipse.

Also, I added an event adapter and fixed the topic id (bug 146029).
Comment 2 Chris Aniszczyk CLA 2007-11-09 11:41:51 EST 
How about it Tom?
Comment 3 BJ Hargrave CLA 2007-11-09 13:43:49 EST 
We also need to make sure that useradmin (and all other bundles which have added an event adapter) do NOT require eventadmin present. That is, the useradmin bundle must not require the eventadmin bundle to be installed or running.

It is hard to tell from the patch if this is the case.
Comment 4 Chris Aniszczyk CLA 2007-11-09 14:06:27 EST 
This is exactly the case BJ.

Everything is all peachy without eventadmin there.
Comment 5 Thomas Watson CLA 2007-11-09 16:35:02 EST 
BJ is not on the CC list so did not see your response.

I have requested Chris to separate the patches into
1) one that only adds the event mappers
2) one that refactors the internal packages
Comment 6 Chris Aniszczyk CLA 2007-11-09 16:58:05 EST 
Created attachment 82580 [details]
org.eclipse.equinox.useradmin.patch

Adds an event adapter. This is pre-refactoring.
Comment 7 Thomas Watson CLA 2007-11-12 16:05:56 EST 
Created attachment 82703 [details]
patch

This patch updates the compiler settings of the project to use the EE.  I found that the LogTracker did not compile on osgi min EE.  I copied the one from event admin impl where we fixed the same issue.
Comment 8 Thomas Watson CLA 2007-11-12 16:06:50 EST 
patch released to M4.
Comment 9 Thomas Watson CLA 2007-11-13 09:15:17 EST 
In bug 209294 Simon makes a good point that the import of the event package should be optional.  I released a fix to useradmin to make the import optional.