208797 – SelectedResourceManager.getCurrentSelection0() should use IAdapterManager

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 208797 - SelectedResourceManager.getCurrentSelection0() should use IAdapterManager

Summary: SelectedResourceManager.getCurrentSelection0() should use IAdapterManager

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	Debug (show other bugs)
Version:	3.3
Hardware:	PC Windows XP

Importance:	P3 enhancement with 1 vote (vote)
Target Milestone:	3.4 M4
Assignee:	Michael Rennie
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	208636
	Show dependency tree

Reported:	2007-11-05 14:17 EST by Nitin Dahyabhai
Modified:	2007-12-10 14:27 EST (History)
CC List:	2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Nitin Dahyabhai

2007-11-05 14:17:47 EST

While looking into a solution for bug 208636, I found that the manager was checking of the selected objects were IAdaptable.  Elements in the outline are frequently core domain objects, and in our case adding the IAdaptable interface would break binary compatibility.  The SelectedResourceManager should call the platform IAdapterManager for non-IAdaptables so that plug-ins can provide a factory and adapter for IResource that way.

Comment 1 Darin Wright

2007-12-06 22:29:21 EST

Fixed in SelectedResourceManager. We now use the adapter manager, and iterate through each element in the selection returning the first resouce adapter encountered.

Comment 2 Darin Wright

2007-12-06 22:29:35 EST

Please verify, Mike.

Comment 3 Michael Rennie

2007-12-10 14:27:45 EST

verified