Community
Participate
Working Groups
Build ID: 3.3 Steps To Reproduce: 1. Profile Hello application from workbench 2. use aggregated mode 3. use * * INCLUDE filter 4. after execution go to Execution statistic and select "charAt" method 5. watch Invocation details 6. sum of "Invoked by" column values in middle pane should match to value in column "calls" in upper pane but it doesn't
Created attachment 82086 [details] proposed patch Please, review patch Alex.
Comment on attachment 82086 [details] proposed patch two issues - invocations count isn't taken into account - parent method calculation uses incorrect invocation objects
Created attachment 82087 [details] proposed patch (remove unused import)
adding self to watch list. I'll compile/test with this patch.
Created attachment 82144 [details] screen dump (jpg) image showing invocation counts
Hi Alex, This is looking pretty good. I'm attaching a screenshot from using it. Its looking like the bottom frame (this method invokes) still has an issue. It looks like in some cases the number of times that this method foo() invokes another method bar() is greater than the total number of times that bar() is called. See the attached screenshot attached, second to last line java.lang.Class.getname(). For another test with Harmony, I found some examples where this number was dramatically greater than the call count. I wanted to send an example with Sun though. I'm attaching another screenshot that seems to suggest the right number here is supposed to be 5. I suspect this means there is a typo in the source but I've not had time to go look. Thx, Chris
Created attachment 82145 [details] another screen shot
Created attachment 82153 [details] example showing big delta note that this one most of the "invokes" pane are much much higher than the total call count for the underlying methods... This is from Harmony M3 running Dacapo Chart
I add dependency from similar bug, but propose to close it as duplicated and move patch to original (Bug 197176). Concerns regarding callee column is caused by Bug 208645 and can be considered in its context. Please, provide feedback. Alex.
this sounds like a good plan to me. Thx, Chris
*** This bug has been marked as a duplicate of bug 197176 ***
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.
