Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 208644 - [prov] zlib error
Summary: [prov] zlib error
Status: RESOLVED WORKSFORME
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Stefan Liebig CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-02 21:00 EDT by Jeff McAffer CLA
Modified: 2008-06-27 17:17 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff McAffer CLA 2007-11-02 21:00:55 EDT 
I was installing the SDK 1101-0010 using the m3 agent ui and about 70% of the way through (I think) I got an error dialog saying 

  Error during phase: install.
    Error unzipping D:\equinox.p2\p2\org.eclipse.equinox.p2.core\cache\plugins\org.eclipse.rcp.source_3.4.0.v20071029-9297EcdEgYiT6nqE3g8ONGHr.jar: Unexpected end of ZLIB input stream
    Error unzipping D:\equinox.p2\p2\org.eclipse.equinox.p2.core\cache\plugins\org.eclipse.rcp.source_3.4.0.v20071029-9297EcdEgYiT6nqE3g8ONGHr.jar: Unexpected end of ZLIB input stream

I'm assuming that this means the downloaded artifact was corrupt.  Its unclear if it is corrupt in the repo or if this was a download problem.
Comment 1 Jeff McAffer CLA 2007-11-02 21:12:43 EDT 
when i redid the install I immediately got the following error (I had not restarted the agent)

  Error during phase: install.
    Error saving manipulator
    Unable to locate bundle manifest: file:/D:/equinox.p2/p2/org.eclipse.equinox.p2.touchpoint.eclipse/plugins/org.eclipse.rcp.source_3.4.0.v20071029-9297EcdEgYiT6nqE3g8ONGHr/

Indeed the folder is there and has some content but certainly no manifest.mf.

perhaps the system things that the RCP source bundle was successfully unzip'd/installed when it actually was not?  

It is unclear how to recover from this.  I exited and restarted the agent.  No joy.  I then poked around in the bundle pool and deleted the partial folder (there was no entry in the artifacts.xml) and the JAR in the download cache and hacked the artifacts.xml to remove the descritor.  (BTW, the JAR was corrupt according to winzip).  I then redid the install.  The RCP source bundle was re-downloaded and the install completed successfully.  I was able to run the installed eclipse.

So it looks like a transport issue or something to do with the unzip execution.
Comment 2 Pascal Rapicault CLA 2007-11-02 22:10:30 EDT 
Since unzip recognizes a corrupted zip, this is a problem with our transport. I have had this a long time ago (in February) but this got fixed and I never saw it again.
To help us track that I propose that we add an MD5 check or a file size check as part of the processing steps.

Long term I think we need to provide an utility checking the integrity of the artifacts being stored. I have opened bug #208647.
Comment 3 Simon Kaegi CLA 2007-11-03 23:01:54 EDT 
This sounds similar to what I encountered in bug 204372.
Comment 4 Pascal Rapicault CLA 2008-01-20 16:39:02 EST 
Is this still a problem?
Comment 5 John Arthorne CLA 2008-06-27 17:17:15 EDT 
This hasn't been reproduced since November. Closing because there have been major changes since then.